Skip to content

Commit fe62615

Browse files
committed
Use ARC to avoid a retain cycle
1 parent e5f3bdd commit fe62615

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

WooCommerce/Classes/ViewRelated/CardPresentPayments/CardReaderConnectionController.swift

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ final class CardReaderConnectionController {
6464
didSetState()
6565
}
6666
}
67-
private var fromController: UIViewController?
67+
private weak var fromController: UIViewController?
6868
private var siteID: Int64
6969
private var knownCardReaderProvider: CardReaderSettingsKnownReaderProvider
7070
private var alerts: CardReaderSettingsAlertsProvider
@@ -572,7 +572,6 @@ private extension CardReaderConnectionController {
572572
private func returnSuccess(connected: Bool) {
573573
self.alerts.dismiss()
574574
self.onCompletion?(.success(connected))
575-
self.fromController = nil
576575
self.state = .idle
577576
}
578577

@@ -581,7 +580,6 @@ private extension CardReaderConnectionController {
581580
private func returnFailure(error: Error) {
582581
self.alerts.dismiss()
583582
self.onCompletion?(.failure(error))
584-
self.fromController = nil
585583
self.state = .idle
586584
}
587585
}

0 commit comments

Comments
 (0)