[Woo POS][Design System] Update onSuccess color, remove legacy text colors, and misc design updates (#15119)

Author: jaclync

WooCommerce/Classes/POS/Colors/Color+POSColorPalette.swift

@@ -46,11 +46,6 @@ extension Color {
     static var posAlert: Color { Color(.posAlert) }
     static var posOnAlert: Color { Color(.posOnAlert) }
 
-    // MARK: - Text Colors
-    static var posPrimaryText: Color { Color(.posPrimaryText) }
-    static var posSecondaryText: Color { Color(.posSecondaryText) }
-    static var posTertiaryText: Color { Color(.posTertiaryText) }
-
     // MARK: - Other
     static var posShadow: Color { Color(.posShadow) }
 }

WooCommerce/Classes/POS/Colors/POSColorPalette.xcassets/posOnSuccess.colorset/Contents.json

@@ -5,9 +5,9 @@
         "color-space" : "srgb",
         "components" : {
           "alpha" : "1.000",
-          "blue" : "0xFF",
-          "green" : "0xFF",
-          "red" : "0xFF"
+          "blue" : "0x17",
+          "green" : "0x15",
+          "red" : "0x10"
         }
       },
       "idiom" : "universal"
@@ -23,9 +23,9 @@
         "color-space" : "srgb",
         "components" : {
           "alpha" : "1.000",
-          "blue" : "0xFF",
-          "green" : "0xFF",
-          "red" : "0xFF"
+          "blue" : "0x17",
+          "green" : "0x15",
+          "red" : "0x10"
         }
       },
       "idiom" : "universal"

WooCommerce/Classes/POS/Colors/POSColorPalette.xcassets/posPrimaryText.colorset/Contents.json

@@ -13,8 +13,8 @@ private extension PointOfSaleCardPresentPaymentPreparingForPaymentMessageViewMod
             comment: "Title shown on the Point of Sale checkout while the reader is being prepared."
         )
         static let message = NSLocalizedString(
-            "pointOfSale.cardPresent.preparingForPayment.message",
-            value: "Preparing card for payment",
+            "pointOfSale.cardPresent.preparingReaderForPayment.message",
+            value: "Preparing reader for payment",
             comment: "Message shown on the Point of Sale checkout while the reader is being prepared."
         )
     }

WooCommerce/Classes/POS/Colors/POSColorPalette.xcassets/posSecondaryText.colorset/Contents.json

@@ -88,7 +88,7 @@ private extension CardReaderConnectionStatusView {
     var connectedFontColor: Color {
         switch backgroundAppearance {
         case .primary:
-            .posPrimaryText
+            .posOnSurface
         case .secondary:
             POSFloatingControlView.secondaryFontColor
         }
@@ -97,7 +97,7 @@ private extension CardReaderConnectionStatusView {
     var disconnectedFontColor: Color {
         switch backgroundAppearance {
         case .primary:
-            .posPrimaryText
+            .posOnSurface
         case .secondary:
             POSFloatingControlView.secondaryFontColor
         }

WooCommerce/Classes/POS/Colors/POSColorPalette.xcassets/posTertiaryText.colorset/Contents.json

@@ -14,16 +14,16 @@ struct PointOfSaleItemListEmptyView: View {
                 .resizable()
                 .aspectRatio(contentMode: .fit)
                 .frame(width: Constants.iconSize, height: Constants.iconSize)
-                .foregroundColor(.posSecondaryText)
+                .foregroundColor(.posOnSurfaceVariantHighest)
             Text(title)
-                .foregroundStyle(Color.posSecondaryText)
+                .foregroundStyle(Color.posOnSurfaceVariantHighest)
                 .font(.posHeading)
             Text(subtitle)
-                .foregroundStyle(Color.posSecondaryText)
+                .foregroundStyle(Color.posOnSurfaceVariantHighest)
                 .font(.posBodyLargeRegular())
                 .padding([.leading, .trailing])
             Text(hint)
-                .foregroundStyle(Color.posSecondaryText)
+                .foregroundStyle(Color.posOnSurfaceVariantHighest)
                 .font(.posBodyLargeRegular())
                 .padding([.leading, .trailing])
             Spacer()

WooCommerce/Classes/POS/Presentation/Card Present Payments/Reader Messages/PointOfSaleCardPresentPaymentPreparingForPaymentMessageViewModel.swift

@@ -18,11 +18,11 @@ struct PointOfSaleItemListErrorView: View {
                     .padding(.bottom)
                 Text(error.title)
                     .accessibilityAddTraits(.isHeader)
-                    .foregroundStyle(Color.posPrimaryText)
+                    .foregroundStyle(Color.posOnSurface)
                     .font(.posHeading)
                     .padding(.bottom, PointOfSaleItemListErrorLayout.verticalPadding)
                 Text(error.subtitle)
-                    .foregroundStyle(Color.posPrimaryText)
+                    .foregroundStyle(Color.posOnSurface)
                     .font(.posBodyLargeRegular())
                     .padding([.leading, .trailing])
                     .padding(.bottom, PointOfSaleItemListErrorLayout.verticalPadding)

WooCommerce/Classes/POS/Presentation/CardReaderConnection/CardReaderConnectionStatusView.swift

@@ -8,7 +8,7 @@ struct PointOfSaleItemListFullscreenView<Content: View>: View {
             VStack(alignment: .center, spacing: PointOfSaleItemListErrorLayout.headerSpacing) {
                 POSHeaderTitleView(
                     title: Localization.title,
-                    foregroundColor: .posSecondaryText
+                    foregroundColor: .posOnSurfaceVariantHighest
                 )
                 Spacer()
             }