ObjectId generation uses outdated specification

[alcaeus]

I noticed that the ObjectId generation uses a machine ID and process ID to generate bytes 4-8. This was replaced with a 5-byte random value that is generated once per process back in 2018 as per the ObjectId Specification. Changing this will also speed up generation of new ObjectIds, as the value can be initialised once per process in a static property, instead of the current logic that runs pack, substr, md5, and gethostname.

[midnight-wonderer]

I was about to mention the same thing:
https://www.mongodb.com/docs/manual/reference/bson-types/#objectid

The new spec is actually better in PHP environments because each request has its own PID, causing the counter to re-randomize for each PID (i.e., for each request). With a 16-bit PID, this would cycle through quickly. Randomizing 5 bytes provides ample space to prevent collisions.

[midnight-wonderer]

There is also this logical error in counter wrapping:

php-objectid/src/ObjectId.php

Line 24 in b68059f

self::$counter = (self::$counter + 1) % 0xffffff;

It should look like this, since the max value is a mask, not a boundary; using it to modulo would be wrong.

Anyway, I created one of my own after seeing the code.
It was a semi-vibe coding, tho; but the tests are mostly handcrafted.

https://github.com/slime-systems/php-object-id
You are welcome to switch over.