modifications as per lint inspection

Author: mzorz

aztec/src/main/kotlin/org/wordpress/aztec/watchers/event/buckets/Bucket.java

@@ -8,7 +8,7 @@
     extend from this class to construct a specific bucket
  */
 public abstract class Bucket {
-    protected ArrayList<UserOperationEvent> mUserOperations = new ArrayList<>();
+    final protected ArrayList<UserOperationEvent> mUserOperations = new ArrayList<>();
     public ArrayList<UserOperationEvent> getUserOperations() {
         return mUserOperations;
     }

aztec/src/main/kotlin/org/wordpress/aztec/watchers/event/sequence/EventSequence.kt

@@ -1,4 +1,4 @@
 package org.wordpress.aztec.watchers.event.sequence
 
-open class EventSequence<TextWatcherEvent>() : ArrayList<TextWatcherEvent>()
+open class EventSequence<TextWatcherEvent> : ArrayList<TextWatcherEvent>()
 

aztec/src/main/kotlin/org/wordpress/aztec/watchers/event/sequence/known/space/API26InWordSpaceInsertionEvent.java

@@ -16,8 +16,8 @@
  This case implements the behavior observed in https://github.com/wordpress-mobile/AztecEditor-Android/issues/555
  */
 public class API26InWordSpaceInsertionEvent extends UserOperationEvent {
-    private static char SPACE = ' ';
-    private static String SPACE_STRING = "" + SPACE;
+    private static final char SPACE = ' ';
+    private static final String SPACE_STRING = "" + SPACE;
     private static final int MAXIMUM_TIME_BETWEEN_EVENTS_IN_PATTERN_MS = 50;
 
     public API26InWordSpaceInsertionEvent() {
@@ -95,8 +95,8 @@ public boolean isUserOperationPartiallyObservedInSequence(@NotNull EventSequence
             // WARNING! When debugging with breakpoints, you should disable this check as time can exceed the 50 MS limit and
             // create undesired behavior.
             if (i > 0) { // only try to compare when we have at least 2 events, so we can compare with the previous one
-                long timestampForPreviousevent = sequence.get(i-1).getTimestamp();
-                long timeDistance = observableEvent.getTimestamp() - timestampForPreviousevent;
+                long timestampForPreviousEvent = sequence.get(i-1).getTimestamp();
+                long timeDistance = observableEvent.getTimestamp() - timestampForPreviousEvent;
                 if (timeDistance > MAXIMUM_TIME_BETWEEN_EVENTS_IN_PATTERN_MS) {
                     return false;
                 }

aztec/src/main/kotlin/org/wordpress/aztec/watchers/event/sequence/known/space/steps/TextWatcherEventDeleteText.java

@@ -10,7 +10,7 @@ public class TextWatcherEventDeleteText extends TextWatcherEvent {
 
     private CharSequence beforeText;
 
-    public TextWatcherEventDeleteText(BeforeTextChangedEventData beforeEventData, OnTextChangedEventData onEventData,
+    private TextWatcherEventDeleteText(BeforeTextChangedEventData beforeEventData, OnTextChangedEventData onEventData,
                                       AfterTextChangedEventData afterEventData) {
         this.beforeEventData = beforeEventData;
         this.onEventData = onEventData;

aztec/src/main/kotlin/org/wordpress/aztec/watchers/event/sequence/known/space/steps/TextWatcherEventInsertText.java

@@ -16,7 +16,7 @@ public TextWatcherEventInsertText() {
 
     }
 
-    public TextWatcherEventInsertText(BeforeTextChangedEventData beforeEventData, OnTextChangedEventData onEventData,
+    private TextWatcherEventInsertText(BeforeTextChangedEventData beforeEventData, OnTextChangedEventData onEventData,
                                       AfterTextChangedEventData afterEventData) {
         this.beforeEventData = beforeEventData;
         this.onEventData = onEventData;

aztec/src/main/kotlin/org/wordpress/aztec/watchers/event/text/TextWatcherEvent.java

@@ -6,11 +6,11 @@ public class TextWatcherEvent {
     protected AfterTextChangedEventData afterEventData;
     private long timestamp;
 
-    public TextWatcherEvent() {
+    protected TextWatcherEvent() {
 
     }
 
-    public TextWatcherEvent(BeforeTextChangedEventData beforeEventData, OnTextChangedEventData onEventData,
+    private TextWatcherEvent(BeforeTextChangedEventData beforeEventData, OnTextChangedEventData onEventData,
                             AfterTextChangedEventData afterEventData) {
         this.beforeEventData = beforeEventData;
         this.onEventData = onEventData;
@@ -47,7 +47,7 @@ public long getTimestamp() {
     }
 
     public boolean testFitsBeforeOnAndAfter() {
-        // always returns false, subclassess should make an assessment and properly return true/false depending
+        // always returns false, subclasses should make an assessment and properly return true/false depending
         // on their specific data contents
         return false;
     }