Skip to content

Commit 0b16cbd

Browse files
committed
Revert "Add leading margin option to headers."
This reverts commit a9df670
1 parent 2736990 commit 0b16cbd

File tree

4 files changed

+8
-30
lines changed

4 files changed

+8
-30
lines changed

aztec/src/main/kotlin/org/wordpress/aztec/AztecText.kt

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -467,33 +467,27 @@ open class AztecText : AppCompatEditText, TextWatcher, UnknownHtmlSpan.OnUnknown
467467
headerStyle = BlockFormatter.HeaderStyles(verticalHeadingMargin, mapOf(
468468
AztecHeadingSpan.Heading.H1 to BlockFormatter.HeaderStyles.HeadingStyle(
469469
styles.getDimensionPixelSize(R.styleable.AztecText_headingOneFontSize, 0),
470-
styles.getColor(R.styleable.AztecText_headingOneFontColor, 0),
471-
styles.getDimensionPixelSize(R.styleable.AztecText_headingOneLeadingMargin, 0)
470+
styles.getColor(R.styleable.AztecText_headingOneFontColor, 0)
472471
),
473472
AztecHeadingSpan.Heading.H2 to BlockFormatter.HeaderStyles.HeadingStyle(
474473
styles.getDimensionPixelSize(R.styleable.AztecText_headingTwoFontSize, 0),
475-
styles.getColor(R.styleable.AztecText_headingTwoFontColor, 0),
476-
styles.getDimensionPixelSize(R.styleable.AztecText_headingTwoLeadingMargin, 0)
474+
styles.getColor(R.styleable.AztecText_headingTwoFontColor, 0)
477475
),
478476
AztecHeadingSpan.Heading.H3 to BlockFormatter.HeaderStyles.HeadingStyle(
479477
styles.getDimensionPixelSize(R.styleable.AztecText_headingThreeFontSize, 0),
480-
styles.getColor(R.styleable.AztecText_headingThreeFontColor, 0),
481-
styles.getDimensionPixelSize(R.styleable.AztecText_headingThreeLeadingMargin, 0)
478+
styles.getColor(R.styleable.AztecText_headingThreeFontColor, 0)
482479
),
483480
AztecHeadingSpan.Heading.H4 to BlockFormatter.HeaderStyles.HeadingStyle(
484481
styles.getDimensionPixelSize(R.styleable.AztecText_headingFourFontSize, 0),
485-
styles.getColor(R.styleable.AztecText_headingFourFontColor, 0),
486-
styles.getDimensionPixelSize(R.styleable.AztecText_headingFourLeadingMargin, 0)
482+
styles.getColor(R.styleable.AztecText_headingFourFontColor, 0)
487483
),
488484
AztecHeadingSpan.Heading.H5 to BlockFormatter.HeaderStyles.HeadingStyle(
489485
styles.getDimensionPixelSize(R.styleable.AztecText_headingFiveFontSize, 0),
490-
styles.getColor(R.styleable.AztecText_headingFiveFontColor, 0),
491-
styles.getDimensionPixelSize(R.styleable.AztecText_headingFiveLeadingMargin, 0)
486+
styles.getColor(R.styleable.AztecText_headingFiveFontColor, 0)
492487
),
493488
AztecHeadingSpan.Heading.H6 to BlockFormatter.HeaderStyles.HeadingStyle(
494489
styles.getDimensionPixelSize(R.styleable.AztecText_headingSixFontSize, 0),
495-
styles.getColor(R.styleable.AztecText_headingSixFontColor, 0),
496-
styles.getDimensionPixelSize(R.styleable.AztecText_headingSixLeadingMargin, 0)
490+
styles.getColor(R.styleable.AztecText_headingSixFontColor, 0)
497491
)
498492
)),
499493
preformatStyle = BlockFormatter.PreformatStyle(

aztec/src/main/kotlin/org/wordpress/aztec/formatting/BlockFormatter.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ class BlockFormatter(editor: AztecText,
6363
data class QuoteStyle(val quoteBackground: Int, val quoteColor: Int, val quoteTextColor: Int, val quoteBackgroundAlpha: Float, val quoteMargin: Int, val quotePadding: Int, val quoteWidth: Int, val verticalPadding: Int)
6464
data class PreformatStyle(val preformatBackground: Int, val preformatBackgroundAlpha: Float, val preformatColor: Int, val verticalPadding: Int, val leadingMargin: Int, val preformatBorderColor: Int, val preformatBorderRadius: Int, val preformatBorderThickness: Int, val preformatTextSize: Int)
6565
data class HeaderStyles(val verticalPadding: Int, val styles: Map<AztecHeadingSpan.Heading, HeadingStyle>) {
66-
data class HeadingStyle(val fontSize: Int, val fontColor: Int, val leadingMargin: Int)
66+
data class HeadingStyle(val fontSize: Int, val fontColor: Int)
6767
}
6868
data class ExclusiveBlockStyles(val enabled: Boolean = false, val verticalParagraphMargin: Int)
6969
data class ParagraphStyle(val verticalMargin: Int)

aztec/src/main/kotlin/org/wordpress/aztec/spans/AztecHeadingSpan.kt

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
package org.wordpress.aztec.spans
22

3-
import android.graphics.Canvas
43
import android.graphics.Paint
54
import android.text.Layout
65
import android.text.Spanned
76
import android.text.TextPaint
8-
import android.text.style.LeadingMarginSpan
97
import android.text.style.LineHeightSpan
108
import android.text.style.MetricAffectingSpan
119
import android.text.style.UpdateLayout
@@ -66,7 +64,7 @@ open class AztecHeadingSpan(
6664
textFormat: ITextFormat,
6765
override var attributes: AztecAttributes,
6866
open var headerStyle: BlockFormatter.HeaderStyles
69-
) : MetricAffectingSpan(), IAztecLineBlockSpan, LineHeightSpan, LeadingMarginSpan, UpdateLayout {
67+
) : MetricAffectingSpan(), IAztecLineBlockSpan, LineHeightSpan, UpdateLayout {
7068
override val TAG: String
7169
get() = heading.tag
7270

@@ -186,7 +184,6 @@ open class AztecHeadingSpan(
186184
}
187185
previousHeadingSize = headingSize
188186
previousSpacing = paint.fontSpacing
189-
paint.fontFeatureSettings
190187
when (headingSize) {
191188
is HeadingSize.Scale -> {
192189
paint.textSize *= heading.scale
@@ -200,13 +197,6 @@ open class AztecHeadingSpan(
200197
}
201198
}
202199

203-
override fun getLeadingMargin(first: Boolean): Int {
204-
return headerStyle.styles[heading]?.leadingMargin?.takeIf { it != 0 } ?: 0
205-
}
206-
207-
override fun drawLeadingMargin(c: Canvas?, p: Paint?, x: Int, dir: Int, top: Int, baseline: Int, bottom: Int,
208-
text: CharSequence?, start: Int, end: Int, first: Boolean, layout: Layout?) = Unit
209-
210200
private fun getHeadingSize(): HeadingSize {
211201
return headerStyle.styles[heading]?.fontSize?.takeIf { it > 0 }?.let { HeadingSize.Size(it) }
212202
?: HeadingSize.Scale(heading.scale)

aztec/src/main/res/values/attrs.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,17 +45,11 @@
4545
<attr name="textColorHint" format="reference|color" />
4646
<attr name="exclusiveBlocks" format="reference|boolean" />
4747
<attr name="headingOneFontSize" format="reference|dimension" />
48-
<attr name="headingOneLeadingMargin" format="reference|dimension" />
4948
<attr name="headingTwoFontSize" format="reference|dimension" />
50-
<attr name="headingTwoLeadingMargin" format="reference|dimension" />
5149
<attr name="headingThreeFontSize" format="reference|dimension" />
52-
<attr name="headingThreeLeadingMargin" format="reference|dimension" />
5350
<attr name="headingFourFontSize" format="reference|dimension" />
54-
<attr name="headingFourLeadingMargin" format="reference|dimension" />
5551
<attr name="headingFiveFontSize" format="reference|dimension" />
56-
<attr name="headingFiveLeadingMargin" format="reference|dimension" />
5752
<attr name="headingSixFontSize" format="reference|dimension" />
58-
<attr name="headingSixLeadingMargin" format="reference|dimension" />
5953
<attr name="headingOneFontColor" format="reference|color" />
6054
<attr name="headingTwoFontColor" format="reference|color" />
6155
<attr name="headingThreeFontColor" format="reference|color" />

0 commit comments

Comments
 (0)