Skip to content

Commit 0b76a25

Browse files
committed
Renamed toolbar height variable to avoid confusion and priority issues in client apps.
1 parent 9f006ac commit 0b76a25

File tree

6 files changed

+14
-14
lines changed

6 files changed

+14
-14
lines changed

app/src/main/res/layout-v17/activity_main.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<org.wordpress.aztec.toolbar.AztecToolbar
99
android:id="@+id/formatting_toolbar"
1010
android:layout_width="match_parent"
11-
android:layout_height="@dimen/format_bar_height"
11+
android:layout_height="@dimen/aztec_format_bar_height"
1212
android:layout_alignParentBottom="true">
1313
</org.wordpress.aztec.toolbar.AztecToolbar>
1414

app/src/main/res/layout/activity_main.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<org.wordpress.aztec.toolbar.AztecToolbar
99
android:id="@+id/formatting_toolbar"
1010
android:layout_width="match_parent"
11-
android:layout_height="@dimen/format_bar_height"
11+
android:layout_height="@dimen/aztec_format_bar_height"
1212
android:layout_alignParentBottom="true">
1313
</org.wordpress.aztec.toolbar.AztecToolbar>
1414

aztec/src/main/res/layout/aztec_format_bar_advanced.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@
2020
<HorizontalScrollView
2121
android:id="@+id/format_bar_button_scroll"
2222
android:layout_width="match_parent"
23-
android:layout_height="@dimen/format_bar_height"
23+
android:layout_height="@dimen/aztec_format_bar_height"
2424
android:layout_gravity="bottom"
2525
android:clipToPadding="false"
2626
android:fillViewport="true"
27-
android:paddingRight="@dimen/format_bar_right_margin"
27+
android:paddingRight="@dimen/aztec_format_bar_right_margin"
2828
tools:ignore="RtlHardcoded,RtlSymmetry">
2929

3030
<LinearLayout
@@ -162,7 +162,7 @@
162162
style="@style/FormatBarButton"
163163
android:layout_width="wrap_content"
164164
android:layout_height="fill_parent"
165-
android:layout_marginLeft="@dimen/format_bar_left_margin"
165+
android:layout_marginLeft="@dimen/aztec_format_bar_left_margin"
166166
android:background="@drawable/format_bar_button_heading_selector"
167167
android:contentDescription="@string/format_bar_description_heading">
168168
</org.wordpress.aztec.toolbar.RippleToggleButton>

aztec/src/main/res/layout/aztec_format_bar_basic.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,19 +19,19 @@
1919

2020
<HorizontalScrollView
2121
android:layout_width="match_parent"
22-
android:layout_height="@dimen/format_bar_height"
22+
android:layout_height="@dimen/aztec_format_bar_height"
2323
android:layout_gravity="bottom"
2424
android:clipToPadding="false"
2525
android:fillViewport="true"
26-
android:paddingRight="@dimen/format_bar_right_margin"
26+
android:paddingRight="@dimen/aztec_format_bar_right_margin"
2727
tools:ignore="RtlHardcoded,RtlSymmetry">
2828

2929
<LinearLayout
3030
android:layout_width="wrap_content"
3131
android:layout_height="wrap_content"
3232
android:clipToPadding="false"
3333
android:orientation="horizontal"
34-
android:paddingRight="@dimen/format_bar_right_margin"
34+
android:paddingRight="@dimen/aztec_format_bar_right_margin"
3535
tools:ignore="RtlHardcoded,RtlSymmetry">
3636

3737
<LinearLayout
@@ -97,7 +97,7 @@
9797
style="@style/FormatBarButton"
9898
android:layout_width="wrap_content"
9999
android:layout_height="fill_parent"
100-
android:layout_marginLeft="@dimen/format_bar_left_margin"
100+
android:layout_marginLeft="@dimen/aztec_format_bar_left_margin"
101101
android:background="@drawable/format_bar_button_heading_selector"
102102
android:contentDescription="@string/format_bar_description_heading">
103103
</org.wordpress.aztec.toolbar.RippleToggleButton>

aztec/src/main/res/values/dimens.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@
2525
<item type="dimen" format="string" name="spacing_multiplier">1.0</item>
2626

2727
<!-- TOOLBAR -->
28-
<dimen name="format_bar_height">48dp</dimen>
29-
<dimen name="format_bar_left_margin">5dp</dimen>
30-
<dimen name="format_bar_right_margin">5dp</dimen>
28+
<dimen name="aztec_format_bar_height">48dp</dimen>
29+
<dimen name="aztec_format_bar_left_margin">5dp</dimen>
30+
<dimen name="aztec_format_bar_right_margin">5dp</dimen>
3131

3232
<dimen name="format_bar_horizontal_divider_height">1dp</dimen>
3333
<dimen name="format_bar_vertical_divider_width">0.6dp</dimen>

aztec/src/main/res/values/styles.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
<resources xmlns:android="http://schemas.android.com/apk/res/android">
33

44
<style name="FormatBarButton">
5-
<item name="android:minWidth">@dimen/format_bar_height</item>
6-
<item name="android:minHeight">@dimen/format_bar_height</item>
5+
<item name="android:minWidth">@dimen/aztec_format_bar_height</item>
6+
<item name="android:minHeight">@dimen/aztec_format_bar_height</item>
77
<item name="android:textOn">@null</item>
88
<item name="android:textOff">@null</item>
99
</style>

0 commit comments

Comments
 (0)