Merge pull request #892 from wordpress-mobile/fix/dont-disable-selection-listener-on-first-char-delete

mchowning · web-flow · commit 5138fed3e55c · 2020-02-07T14:29:43.000-05:00
Last char is when the length is now zero
diff --git a/aztec/src/main/kotlin/org/wordpress/aztec/watchers/ZeroIndexContentWatcher.kt b/aztec/src/main/kotlin/org/wordpress/aztec/watchers/ZeroIndexContentWatcher.kt
@@ -27,7 +27,10 @@ class ZeroIndexContentWatcher(aztecText: AztecText) : TextWatcher {
 
         val aztecText = aztecTextRef.get()
         // last character was removed
-        if (aztecText != null && textChangedEventDetails.inputEnd == 0 && textChangedEventDetails.inputStart == 1) {
+        if (aztecText != null
+                && text.length == 0
+                && textChangedEventDetails.inputEnd == 0
+                && textChangedEventDetails.inputStart == 1) {
             aztecText.disableOnSelectionListener()
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,10 @@ class ZeroIndexContentWatcher(aztecText: AztecText) : TextWatcher {`
`27`	`27`
`28`	`28`	`val aztecText = aztecTextRef.get()`
`29`	`29`	`// last character was removed`
`30`		`- if (aztecText != null && textChangedEventDetails.inputEnd == 0 && textChangedEventDetails.inputStart == 1) {`
	`30`	`+ if (aztecText != null`
	`31`	`+ && text.length == 0`
	`32`	`+ && textChangedEventDetails.inputEnd == 0`
	`33`	`+ && textChangedEventDetails.inputStart == 1) {`
`31`	`34`	`aztecText.disableOnSelectionListener()`
`32`	`35`	`}`
`33`	`36`	`}`