Merge pull request #904 from wordpress-mobile/release/v1.3.40

Release/v1.3.40

Author: anitaa1990

.idea/inspectionProfiles/profiles_settings.xml

@@ -1,5 +1,24 @@
 # Changelog
 
+## [1.3.40](https://github.com/wordpress-mobile/AztecEditor-Android/releases/tag/v1.3.40)
+### Changed
+- Adds support to to customise styles for the Aztec Toolbar
+
+## [1.3.39](https://github.com/wordpress-mobile/AztecEditor-Android/releases/tag/v1.3.39)
+### Fixed
+- Move media button initialization to avoid crash when advanced toolbar is enabled and media button is disabled
+
+## [1.3.38](https://github.com/wordpress-mobile/AztecEditor-Android/releases/tag/v1.3.38)
+### Fixed
+- When text changes, only disable selection listener if text is empty
+
+## [1.3.37](https://github.com/wordpress-mobile/AztecEditor-Android/releases/tag/v1.3.37)
+### Fixed
+- Resolved clipboard issue on Android 7
+### Changed
+- Improved TalkBack handling of formatting toolbar
+- Added ability to register an observer for all the changes to the AztecText object
+
 ## [1.3.36](https://github.com/wordpress-mobile/AztecEditor-Android/releases/tag/v1.3.36)
 ### Changed
 - Implement start and reversed in lists

CHANGELOG.md

@@ -105,7 +105,7 @@ repositories {
 ```
 ```gradle
 dependencies {
-    api ('com.github.wordpress-mobile.WordPress-Aztec-Android:aztec:v1.3.36')
+    api ('com.github.wordpress-mobile.WordPress-Aztec-Android:aztec:v1.3.40')
 }
 ```
 

README.md

@@ -11,6 +11,7 @@ android {
         targetSdkVersion 28
         versionCode 1
         versionName "1.0"
+        vectorDrawables.useSupportLibrary = true
         testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
     }
 

app/build.gradle

@@ -29,8 +29,8 @@ import android.widget.PopupMenu
 import android.widget.ToggleButton
 import androidx.appcompat.app.AlertDialog
 import androidx.appcompat.app.AppCompatActivity
+import androidx.appcompat.content.res.AppCompatResources
 import androidx.core.app.ActivityCompat.OnRequestPermissionsResultCallback
-import androidx.core.content.ContextCompat
 import androidx.core.content.FileProvider
 import org.wordpress.android.util.AppLog
 import org.wordpress.android.util.ImageUtils
@@ -339,7 +339,7 @@ open class MainActivity : AppCompatActivity(),
         aztec.visualEditor.setOverlay(predicate, 0, ColorDrawable(0x80000000.toInt()), Gravity.FILL)
         aztec.visualEditor.updateElementAttributes(predicate, attrs)
 
-        val progressDrawable = ContextCompat.getDrawable(this, android.R.drawable.progress_horizontal)!!
+        val progressDrawable = AppCompatResources.getDrawable(this, android.R.drawable.progress_horizontal)!!
         // set the height of the progress bar to 2 (it's in dp since the drawable will be adjusted by the span)
         progressDrawable.setBounds(0, 0, 0, 4)
 
@@ -361,7 +361,7 @@ open class MainActivity : AppCompatActivity(),
 
                 if (attrs.hasAttribute("video")) {
                     attrs.removeAttribute(attrs.getIndex("video"))
-                    aztec.visualEditor.setOverlay(predicate, 0, ContextCompat.getDrawable(this, android.R.drawable.ic_media_play), Gravity.CENTER)
+                    aztec.visualEditor.setOverlay(predicate, 0, AppCompatResources.getDrawable(this, android.R.drawable.ic_media_play), Gravity.CENTER)
                 }
 
                 aztec.visualEditor.updateElementAttributes(predicate, attrs)

app/src/main/kotlin/org/wordpress/aztec/demo/MainActivity.kt

@@ -5,8 +5,12 @@ import org.wordpress.aztec.ITextFormat
 import org.wordpress.aztec.toolbar.IToolbarAction
 import org.wordpress.aztec.toolbar.ToolbarActionType
 
-enum class MediaToolbarAction constructor(override val buttonId: Int, override val actionType: ToolbarActionType,
-                                          override val textFormats: Set<ITextFormat> = setOf()) : IToolbarAction {
-    GALLERY(R.id.media_bar_button_gallery, ToolbarActionType.OTHER, setOf(AztecTextFormat.FORMAT_NONE)),
-    CAMERA(R.id.media_bar_button_camera, ToolbarActionType.OTHER, setOf(AztecTextFormat.FORMAT_NONE))
+enum class MediaToolbarAction constructor(
+        override val buttonId: Int,
+        override val buttonDrawableRes: Int,
+        override val actionType: ToolbarActionType,
+        override val textFormats: Set<ITextFormat> = setOf()
+) : IToolbarAction {
+    GALLERY(R.id.media_bar_button_gallery, R.drawable.media_bar_button_image_multiple_selector, ToolbarActionType.OTHER, setOf(AztecTextFormat.FORMAT_NONE)),
+    CAMERA(R.id.media_bar_button_camera, R.drawable.media_bar_button_camera_selector, ToolbarActionType.OTHER, setOf(AztecTextFormat.FORMAT_NONE))
 }

app/src/main/kotlin/org/wordpress/aztec/demo/MediaToolbarAction.kt

@@ -1,9 +1,10 @@
 <?xml version="1.0" encoding="utf-8"?>
 
-<selector
-    xmlns:android="http://schemas.android.com/apk/res/android" >
+<animated-selector xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:tools="http://schemas.android.com/tools"
+    tools:targetApi="lollipop">
 
     <item android:drawable="@drawable/ic_action_redo_white_30_24dp" android:state_enabled="false" />
     <item android:drawable="@drawable/ic_action_redo_white_24dp" />
 
-</selector>
+</animated-selector>

app/src/main/res/drawable/ic_action_redo_selector.xml

@@ -1,9 +1,10 @@
 <?xml version="1.0" encoding="utf-8"?>
 
-<selector
-    xmlns:android="http://schemas.android.com/apk/res/android" >
+<animated-selector xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:tools="http://schemas.android.com/tools"
+    tools:targetApi="lollipop">
 
     <item android:drawable="@drawable/ic_action_undo_white_30_24dp" android:state_enabled="false" />
     <item android:drawable="@drawable/ic_action_undo_white_24dp" />
 
-</selector>
+</animated-selector>

app/src/main/res/drawable/ic_action_undo_selector.xml

@@ -7,7 +7,7 @@
 
     <!-- @color/grey_darken_20 -->
     <path
-        android:fillColor="#ff4f748e"
+        android:fillColor="?attr/toolbarIconNormalColor"
         android:pathData="M29,24c0,1.7-1.3,3-3,3s-3-1.3-3-3s1.3-3,3-3S29,22.3,29,24zM34,19v11c0,1.1-0.9,2-2,2H16c-1.1,0-2-0.9-2-2V19c0-1.1,0.9-2,2-2v-1h4v1h2l1-2h6l1,2h2C33.1,17,34,17.9,34,19zM19.5,21c0-0.8-0.7-1.5-1.5-1.5s-1.5,0.7-1.5,1.5s0.7,1.5,1.5,1.5S19.5,21.8,19.5,21z M31,24c0-2.8-2.2-5-5-5s-5,2.2-5,5s2.2,5,5,5S31,26.8,31,24z">
     </path>
 

app/src/main/res/drawable/media_bar_button_camera.xml

@@ -7,7 +7,7 @@
 
     <!-- @color/grey_lighten_20 -->
     <path
-        android:fillColor="#ffc8d7e1"
+        android:fillColor="?attr/toolbarIconDisabledColor"
         android:pathData="M29,24c0,1.7-1.3,3-3,3s-3-1.3-3-3s1.3-3,3-3S29,22.3,29,24zM34,19v11c0,1.1-0.9,2-2,2H16c-1.1,0-2-0.9-2-2V19c0-1.1,0.9-2,2-2v-1h4v1h2l1-2h6l1,2h2C33.1,17,34,17.9,34,19zM19.5,21c0-0.8-0.7-1.5-1.5-1.5s-1.5,0.7-1.5,1.5s0.7,1.5,1.5,1.5S19.5,21.8,19.5,21z M31,24c0-2.8-2.2-5-5-5s-5,2.2-5,5s2.2,5,5,5S31,26.8,31,24z">
     </path>