Merge pull request #707 from wordpress-mobile/issue/705-fix-set-remove-attribute-crashes

Do not crash if Attributes->`setValue` and `removeAttribute` fail

Author: hypest

aztec/src/main/kotlin/org/wordpress/aztec/AztecAttributes.kt

@@ -1,26 +1,55 @@
 package org.wordpress.aztec
 
+import org.wordpress.android.util.AppLog
 import org.xml.sax.Attributes
 import org.xml.sax.helpers.AttributesImpl
 
 class AztecAttributes(attributes: Attributes = AttributesImpl()) : AttributesImpl(attributes) {
     fun setValue(key: String, value: String) {
         val index = getIndex(key)
+
         if (index == -1) {
-            addAttribute("", key, key, "string", value)
+            try {
+                addAttribute("", key, key, "string", value)
+            } catch (e: ArrayIndexOutOfBoundsException) {
+                // https://github.com/wordpress-mobile/AztecEditor-Android/issues/705
+                AppLog.e(AppLog.T.EDITOR, "Error adding attribute with name: $key and value: $value")
+                logInternalState()
+                throw e
+            }
         } else {
             setValue(index, value)
         }
     }
 
+    private fun logInternalState() {
+        AppLog.e(AppLog.T.EDITOR, "Dumping internal state:")
+        AppLog.e(AppLog.T.EDITOR, "length = $length")
+        // Since the toString can throw OOB error we need to wrap it in a try/catch
+        try {
+            AppLog.e(AppLog.T.EDITOR, toString())
+        } catch (e: ArrayIndexOutOfBoundsException) {
+            // No need to log anything here. `toString` already writes to log details, but we need to shallow the exception
+            // we don't want to crash logging state of the app
+        }
+    }
+
     fun isEmpty(): Boolean {
         return length == 0
     }
 
     fun removeAttribute(key: String) {
         if (hasAttribute(key)) {
             val index = getIndex(key)
-            removeAttribute(index)
+            try {
+                removeAttribute(index)
+            } catch (e: ArrayIndexOutOfBoundsException) {
+                // https://github.com/wordpress-mobile/AztecEditor-Android/issues/705
+                AppLog.e(AppLog.T.EDITOR, "Tried to remove attribute: $key that is not in the list")
+                AppLog.e(AppLog.T.EDITOR, "Reported to be at index: $index")
+                logInternalState()
+                throw e
+            }
         }
     }
 
@@ -30,12 +59,20 @@ class AztecAttributes(attributes: Attributes = AttributesImpl()) : AttributesImp
 
     override fun toString(): String {
         val sb = StringBuilder()
-        for (i in 0..this.length - 1) {
-            sb.append(this.getLocalName(i))
-            sb.append("=\"")
-            sb.append(this.getValue(i))
-            sb.append("\" ")
+        try {
+            for (i in 0..this.length - 1) {
+                sb.append(this.getLocalName(i))
+                sb.append("=\"")
+                sb.append(this.getValue(i))
+                sb.append("\" ")
+            }
+        } catch (e: ArrayIndexOutOfBoundsException) {
+            // https://github.com/wordpress-mobile/AztecEditor-Android/issues/705
+            AppLog.e(AppLog.T.EDITOR, "IOOB occurred in toString. Dumping partial state:")
+            AppLog.e(AppLog.T.EDITOR, sb.trimEnd().toString())
+            throw e
         }
+
         return sb.trimEnd().toString()
     }
 }