Build: Extract common sdk versions to root build gradle for all modules

ParaskP7 · ParaskP7 · commit a0ad436d7004 · 2022-11-17T17:04:00.000+02:00
This will now make sure that from now on all modules will be pointing to
the same 'min/compile/targetSdkVersion' versions, making such upgrades
much more straightforward as that will apply to all modules. This will
alleviate the risk of forgetting to update a specific module, or set of
modules due to an oversight.
diff --git a/app/build.gradle b/app/build.gradle
@@ -4,12 +4,12 @@ plugins {
 }
 
 android {
-    compileSdkVersion 28
+    compileSdkVersion rootProject.compileSdkVersion
 
     defaultConfig {
         applicationId "org.wordpress.aztec"
-        minSdkVersion commonMinSdkVersion
-        targetSdkVersion commonTargetSdkVersion
+        minSdkVersion rootProject.minSdkVersion
+        targetSdkVersion rootProject.targetSdkVersion
         versionCode 1
         versionName "1.0"
         vectorDrawables.useSupportLibrary = true
diff --git a/aztec/build.gradle b/aztec/build.gradle
@@ -5,11 +5,11 @@ plugins {
 }
 
 android {
-    compileSdkVersion 28
+    compileSdkVersion rootProject.compileSdkVersion
 
     defaultConfig {
-        minSdkVersion commonMinSdkVersion
-        targetSdkVersion commonTargetSdkVersion
+        minSdkVersion rootProject.minSdkVersion
+        targetSdkVersion rootProject.targetSdkVersion
         versionName "1.0"
         vectorDrawables.useSupportLibrary = true
     }
diff --git a/build.gradle b/build.gradle
@@ -62,6 +62,12 @@ subprojects {
     }
 }
 
+ext {
+    minSdkVersion = 21
+    compileSdkVersion = 28
+    targetSdkVersion = 31
+}
+
 ext {
     gradlePluginVersion = '3.3.1'
     kotlinCoroutinesVersion = '1.1.0'
@@ -73,8 +79,6 @@ ext {
     jSoupVersion = '1.11.3'
     wordpressUtilsVersion = 'trunk-1ed207c03d2242b6fc3d74f9e388e9163cbc82a6'
     espressoVersion = '3.0.1'
-    commonTargetSdkVersion = 31
-    commonMinSdkVersion = 21
 
     aztecProjectDependency = project.hasProperty("aztecVersion") ? "org.wordpress:aztec:${project.getProperty("aztecVersion")}" : project(":aztec")
 }
diff --git a/glide-loader/build.gradle b/glide-loader/build.gradle
@@ -5,11 +5,11 @@ plugins {
 }
 
 android {
-    compileSdkVersion 28
+    compileSdkVersion rootProject.compileSdkVersion
 
     defaultConfig {
-        minSdkVersion commonMinSdkVersion
-        targetSdkVersion commonTargetSdkVersion
+        minSdkVersion rootProject.minSdkVersion
+        targetSdkVersion rootProject.targetSdkVersion
         versionCode 1
         versionName "1.0"
 
diff --git a/media-placeholders/build.gradle b/media-placeholders/build.gradle
@@ -5,11 +5,11 @@ plugins {
 }
 
 android {
-    compileSdk 28
+    compileSdkVersion rootProject.compileSdkVersion
 
     defaultConfig {
-        minSdkVersion commonMinSdkVersion
-        targetSdkVersion commonTargetSdkVersion
+        minSdkVersion rootProject.minSdkVersion
+        targetSdkVersion rootProject.targetSdkVersion
         versionName "1.0"
     }
 
diff --git a/picasso-loader/build.gradle b/picasso-loader/build.gradle
@@ -5,11 +5,11 @@ plugins {
 }
 
 android {
-    compileSdkVersion 28
+    compileSdkVersion rootProject.compileSdkVersion
 
     defaultConfig {
-        minSdkVersion commonMinSdkVersion
-        targetSdkVersion commonTargetSdkVersion
+        minSdkVersion rootProject.minSdkVersion
+        targetSdkVersion rootProject.targetSdkVersion
         versionCode 1
         versionName "1.0"
     }
diff --git a/wordpress-comments/build.gradle b/wordpress-comments/build.gradle
@@ -5,11 +5,11 @@ plugins {
 }
 
 android {
-    compileSdkVersion 28
+    compileSdkVersion rootProject.compileSdkVersion
 
     defaultConfig {
-        minSdkVersion commonMinSdkVersion
-        targetSdkVersion commonTargetSdkVersion
+        minSdkVersion rootProject.minSdkVersion
+        targetSdkVersion rootProject.targetSdkVersion
         versionName "1.0"
         vectorDrawables.useSupportLibrary = true
     }
diff --git a/wordpress-shortcodes/build.gradle b/wordpress-shortcodes/build.gradle
@@ -5,11 +5,11 @@ plugins {
 }
 
 android {
-    compileSdkVersion 28
+    compileSdkVersion rootProject.compileSdkVersion
 
     defaultConfig {
-        minSdkVersion commonMinSdkVersion
-        targetSdkVersion commonTargetSdkVersion
+        minSdkVersion rootProject.minSdkVersion
+        targetSdkVersion rootProject.targetSdkVersion
         versionName "1.0"
     }
 

Original file line number	Diff line number	Diff line change
`@@ -5,11 +5,11 @@ plugins {`
`5`	`5`	`}`
`6`	`6`
`7`	`7`	`android {`
`8`		`- compileSdkVersion 28`
	`8`	`+ compileSdkVersion rootProject.compileSdkVersion`
`9`	`9`
`10`	`10`	`defaultConfig {`
`11`		`- minSdkVersion commonMinSdkVersion`
`12`		`- targetSdkVersion commonTargetSdkVersion`
	`11`	`+ minSdkVersion rootProject.minSdkVersion`
	`12`	`+ targetSdkVersion rootProject.targetSdkVersion`
`13`	`13`	`versionName "1.0"`
`14`	`14`	`vectorDrawables.useSupportLibrary = true`
`15`	`15`	`}`
Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,12 @@ subprojects {`
`62`	`62`	`}`
`63`	`63`	`}`
`64`	`64`
	`65`	`+ext {`
	`66`	`+ minSdkVersion = 21`
	`67`	`+ compileSdkVersion = 28`
	`68`	`+ targetSdkVersion = 31`
	`69`	`+}`
	`70`	`+`
`65`	`71`	`ext {`
`66`	`72`	`gradlePluginVersion = '3.3.1'`
`67`	`73`	`kotlinCoroutinesVersion = '1.1.0'`
`@@ -73,8 +79,6 @@ ext {`
`73`	`79`	`jSoupVersion = '1.11.3'`
`74`	`80`	`wordpressUtilsVersion = 'trunk-1ed207c03d2242b6fc3d74f9e388e9163cbc82a6'`
`75`	`81`	`espressoVersion = '3.0.1'`
`76`		`- commonTargetSdkVersion = 31`
`77`		`- commonMinSdkVersion = 21`
`78`	`82`
`79`	`83`	`aztecProjectDependency = project.hasProperty("aztecVersion") ? "org.wordpress:aztec:${project.getProperty("aztecVersion")}" : project(":aztec")`
`80`	`84`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,11 +5,11 @@ plugins {`
`5`	`5`	`}`
`6`	`6`
`7`	`7`	`android {`
`8`		`- compileSdk 28`
	`8`	`+ compileSdkVersion rootProject.compileSdkVersion`
`9`	`9`
`10`	`10`	`defaultConfig {`
`11`		`- minSdkVersion commonMinSdkVersion`
`12`		`- targetSdkVersion commonTargetSdkVersion`
	`11`	`+ minSdkVersion rootProject.minSdkVersion`
	`12`	`+ targetSdkVersion rootProject.targetSdkVersion`
`13`	`13`	`versionName "1.0"`
`14`	`14`	`}`
`15`	`15`