Merge pull request #949 from wordpress-mobile/update/gb-prevent-update-selected-styles-on-change

fluiddot · web-flow · commit a58cd778f9d8 · 2022-01-05T12:13:31.000+01:00
Prevent update selected styles when text changes on Gutenberg mode
diff --git a/aztec/src/main/kotlin/org/wordpress/aztec/AztecText.kt b/aztec/src/main/kotlin/org/wordpress/aztec/AztecText.kt
@@ -1048,7 +1048,10 @@ open class AztecText : AppCompatEditText, TextWatcher, UnknownHtmlSpan.OnUnknown
         }
 
         onSelectionChangedListener?.onSelectionChanged(selStart, selEnd)
-        setSelectedStyles(getAppliedStyles(selStart, selEnd))
+        // Gutenberg controls the selected styles so we need to prevent Aztec to modify them
+        if (!isInGutenbergMode) {
+            setSelectedStyles(getAppliedStyles(selStart, selEnd))
+        }
 
         isLeadingStyleRemoved = false
     }

Original file line number	Diff line number	Diff line change
`@@ -1048,7 +1048,10 @@ open class AztecText : AppCompatEditText, TextWatcher, UnknownHtmlSpan.OnUnknown`
`1048`	`1048`	`}`
`1049`	`1049`
`1050`	`1050`	`onSelectionChangedListener?.onSelectionChanged(selStart, selEnd)`
`1051`		`- setSelectedStyles(getAppliedStyles(selStart, selEnd))`
	`1051`	`+ // Gutenberg controls the selected styles so we need to prevent Aztec to modify them`
	`1052`	`+ if (!isInGutenbergMode) {`
	`1053`	`+ setSelectedStyles(getAppliedStyles(selStart, selEnd))`
	`1054`	`+ }`
`1052`	`1055`
`1053`	`1056`	`isLeadingStyleRemoved = false`
`1054`	`1057`	`}`