Merge pull request #290 from wordpress-mobile/issue/287-crash-deleting-heading

Fix heading deletion crash

Author: 0nko

aztec/src/main/kotlin/org/wordpress/aztec/handlers/HeadingHandler.kt

@@ -44,7 +44,13 @@ class HeadingHandler : BlockHandler<AztecHeadingSpan>(AztecHeadingSpan::class.ja
     }
 
     override fun handleEndOfBufferMarker() {
-        // adjust the block end to only include the chars before the end-of-text marker. A newline will be there.
+        if (block.start == markerIndex) {
+            // ok, this list item has the marker as its first char so, nothing more to do here.
+            return
+        }
+
+        // the heading has bled over to the marker so, let's adjust its range to just before the marker.
+        //  There's a newline there hopefully :)
         block.end = markerIndex
     }
 

aztec/src/test/kotlin/org/wordpress/aztec/HeadingTest.kt

@@ -234,4 +234,17 @@ class HeadingTest() {
         editText.text.delete(mark - 1, mark)
         Assert.assertEquals("<h1 foo=\"bar\">Heading 1unstyled</h1>", editText.toHtml())
     }
+
+    @Test
+    @Throws(Exception::class)
+    fun deleteHeadingChars_Issue287() {
+        editText.fromHtml("<h1>he</h1>")
+
+        var l = safeLength(editText)
+        editText.text.delete(l - 1, l)
+
+        l = safeLength(editText)
+        editText.text.delete(l - 1, l)
+        Assert.assertEquals("<h1></h1>", editText.toHtml())
+    }
 }