Skip to content

Commit d15a322

Browse files
committed
Fix for onMediaDeleted called unnecessarily in API25.
1 parent 54415d2 commit d15a322

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

aztec/src/main/kotlin/org/wordpress/aztec/AztecText.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,8 @@ import org.wordpress.aztec.util.AztecLog
8888
import org.wordpress.aztec.util.SpanWrapper
8989
import org.wordpress.aztec.util.coerceToHtmlText
9090
import org.wordpress.aztec.watchers.BlockElementWatcher
91-
import org.wordpress.aztec.watchers.DeleteMediaElementWatcherAPI26AndHigher
92-
import org.wordpress.aztec.watchers.DeleteMediaElementWatcherPreAPI26
91+
import org.wordpress.aztec.watchers.DeleteMediaElementWatcherAPI25AndHigher
92+
import org.wordpress.aztec.watchers.DeleteMediaElementWatcherPreAPI25
9393
import org.wordpress.aztec.watchers.EndOfBufferMarkerAdder
9494
import org.wordpress.aztec.watchers.EndOfParagraphMarkerAdder
9595
import org.wordpress.aztec.watchers.FullWidthImageElementWatcher
@@ -446,10 +446,10 @@ class AztecText : AppCompatEditText, TextWatcher, UnknownHtmlSpan.OnUnknownHtmlT
446446
EndOfBufferMarkerAdder.install(this)
447447
ZeroIndexContentWatcher.install(this)
448448

449-
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
450-
DeleteMediaElementWatcherAPI26AndHigher.install(this)
449+
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N_MR1) {
450+
DeleteMediaElementWatcherAPI25AndHigher.install(this)
451451
} else {
452-
DeleteMediaElementWatcherPreAPI26.install(this)
452+
DeleteMediaElementWatcherPreAPI25.install(this)
453453
}
454454

455455
// History related logging has to happen before the changes in [ParagraphCollapseRemover]

aztec/src/main/kotlin/org/wordpress/aztec/watchers/DeleteMediaElementWatcherAPI26AndHigher.kt renamed to aztec/src/main/kotlin/org/wordpress/aztec/watchers/DeleteMediaElementWatcherAPI25AndHigher.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import org.wordpress.aztec.AztecText
66
import org.wordpress.aztec.spans.AztecMediaSpan
77
import java.lang.ref.WeakReference
88

9-
class DeleteMediaElementWatcherAPI26AndHigher(aztecText: AztecText) : TextWatcher {
9+
class DeleteMediaElementWatcherAPI25AndHigher(aztecText: AztecText) : TextWatcher {
1010
private val aztecTextRef: WeakReference<AztecText?> = WeakReference(aztecText)
1111
private var deleted = false
1212
private var queueHasBeenPopulatedInThisTimeframe = false
@@ -55,7 +55,7 @@ class DeleteMediaElementWatcherAPI26AndHigher(aztecText: AztecText) : TextWatche
5555

5656
companion object {
5757
fun install(text: AztecText) {
58-
text.addTextChangedListener(DeleteMediaElementWatcherAPI26AndHigher(text))
58+
text.addTextChangedListener(DeleteMediaElementWatcherAPI25AndHigher(text))
5959
}
6060
}
6161
}

aztec/src/main/kotlin/org/wordpress/aztec/watchers/DeleteMediaElementWatcherPreAPI26.kt renamed to aztec/src/main/kotlin/org/wordpress/aztec/watchers/DeleteMediaElementWatcherPreAPI25.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import org.wordpress.aztec.AztecText
66
import org.wordpress.aztec.spans.AztecMediaSpan
77
import java.lang.ref.WeakReference
88

9-
class DeleteMediaElementWatcherPreAPI26(aztecText: AztecText) : TextWatcher {
9+
class DeleteMediaElementWatcherPreAPI25(aztecText: AztecText) : TextWatcher {
1010
private val aztecTextRef: WeakReference<AztecText?> = WeakReference(aztecText)
1111

1212
override fun beforeTextChanged(text: CharSequence, start: Int, count: Int, after: Int) {
@@ -32,7 +32,7 @@ class DeleteMediaElementWatcherPreAPI26(aztecText: AztecText) : TextWatcher {
3232

3333
companion object {
3434
fun install(text: AztecText) {
35-
text.addTextChangedListener(DeleteMediaElementWatcherPreAPI26(text))
35+
text.addTextChangedListener(DeleteMediaElementWatcherPreAPI25(text))
3636
}
3737
}
3838
}

0 commit comments

Comments
 (0)