Change ToggleButton to Button for Accessibility

ToggleButton is read as a switch by TalkBack even when it's being used as a button in the formatting toolbar so this function strips that behavior away so that it's announced as a button.

Author: jd-alexander

aztec/src/main/kotlin/org/wordpress/aztec/util/Extensions.kt

@@ -5,7 +5,15 @@ import android.content.Context
 import android.text.Editable
 import android.text.Spannable
 import android.text.Spanned
+import android.view.View
+import android.view.accessibility.AccessibilityNodeInfo.ACTION_CLICK
+import android.widget.Button
+import android.widget.ToggleButton
+import androidx.core.view.AccessibilityDelegateCompat
+import androidx.core.view.ViewCompat
+import androidx.core.view.accessibility.AccessibilityNodeInfoCompat
 import org.wordpress.aztec.AztecParser
+import org.wordpress.aztec.R
 
 fun Editable.getLast(kind: Class<*>): Any? {
     val spans = this.getSpans(0, this.length, kind)
@@ -55,4 +63,19 @@ fun ClipData.Item.coerceToHtmlText(parser: AztecParser): String {
     }
 
     return text.toString()
-}
+}
+
+fun ToggleButton.convertToButtonStateForAccessibility() {
+    ViewCompat.setAccessibilityDelegate(this, object : AccessibilityDelegateCompat() {
+        override fun onInitializeAccessibilityNodeInfo(host: View?, info: AccessibilityNodeInfoCompat?) {
+            super.onInitializeAccessibilityNodeInfo(host, info)
+            info?.className = Button::class.java.name
+            info?.isCheckable = false
+            info?.isLongClickable = false
+            info?.addAction(AccessibilityNodeInfoCompat.AccessibilityActionCompat(ACTION_CLICK, context.getString(R.string.accessibility_action_click_label)))
+            info?.removeAction(AccessibilityNodeInfoCompat.AccessibilityActionCompat.ACTION_LONG_CLICK)
+        }
+    })
+}
+
+

aztec/src/main/res/values/strings.xml

@@ -2,7 +2,7 @@
 
     <!-- GENERAL -->
     <string name="cursor_moved">Cursor moved</string>
-    <string name="samsung_disabled_custom_clipboard">Sorry, this feature is disabled on Android 8. Please use the Paste action instead.</string>
+    <string name="accessibility_action_click_label">activate</string>
 
     <!-- LINK DIALOG -->
     <string name="link_dialog_title">Insert link</string>