Skip to content

Commit da8f1f2

Browse files
committed
Rename toolbar click listener methods for consistency
1 parent 9450dcd commit da8f1f2

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

app/src/main/kotlin/org/wordpress/aztec/demo/MainActivity.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -665,10 +665,7 @@ class MainActivity : AppCompatActivity(),
665665
override fun onToolbarHeadingButtonClicked() {
666666
}
667667

668-
override fun onToolbarListButtonClicked() {
669-
}
670-
671-
override fun onToolbarHtmlModeClicked() {
668+
override fun onToolbarHtmlButtonClicked() {
672669
val uploadingPredicate = object : AztecText.AttributePredicate {
673670
override fun matches(attrs: Attributes): Boolean {
674671
return attrs.getIndex("uploading") > -1
@@ -684,7 +681,10 @@ class MainActivity : AppCompatActivity(),
684681
}
685682
}
686683

687-
override fun onToolbarAddMediaClicked() {
684+
override fun onToolbarListButtonClicked() {
685+
}
686+
687+
override fun onToolbarMediaButtonClicked() {
688688
mediaMenu = PopupMenu(this, formattingToolbar)
689689
mediaMenu?.setOnMenuItemClickListener(this)
690690
mediaMenu?.inflate(R.menu.media)

aztec/src/main/kotlin/org/wordpress/aztec/toolbar/AztecToolbar.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ class AztecToolbar : FrameLayout, OnMenuItemClickListener {
149149
}
150150
KeyEvent.KEYCODE_M -> {
151151
if (event.isAltPressed && event.isCtrlPressed) { // Media = Alt + Ctrl + M
152-
aztecToolbarListener?.onToolbarAddMediaClicked()
152+
aztecToolbarListener?.onToolbarMediaButtonClicked()
153153
findViewById(ToolbarAction.ADD_MEDIA.buttonId).performClick()
154154
return true
155155
}
@@ -424,7 +424,7 @@ class AztecToolbar : FrameLayout, OnMenuItemClickListener {
424424
//other toolbar action
425425
when (action) {
426426
ToolbarAction.ADD_MEDIA -> {
427-
aztecToolbarListener?.onToolbarAddMediaClicked()
427+
aztecToolbarListener?.onToolbarMediaButtonClicked()
428428
}
429429
ToolbarAction.HEADING -> {
430430
aztecToolbarListener?.onToolbarHeadingButtonClicked()
@@ -439,7 +439,7 @@ class AztecToolbar : FrameLayout, OnMenuItemClickListener {
439439
editor!!.showLinkDialog()
440440
}
441441
ToolbarAction.HTML -> {
442-
aztecToolbarListener?.onToolbarHtmlModeClicked()
442+
aztecToolbarListener?.onToolbarHtmlButtonClicked()
443443
}
444444
ToolbarAction.ELLIPSIS_COLLAPSE -> {
445445
aztecToolbarListener?.onToolbarExpandButtonClicked()

aztec/src/main/kotlin/org/wordpress/aztec/toolbar/AztecToolbarClickListener.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@ package org.wordpress.aztec.toolbar
33
import org.wordpress.aztec.TextFormat
44

55
interface AztecToolbarClickListener {
6-
fun onToolbarAddMediaClicked()
7-
fun onToolbarHtmlModeClicked()
86
fun onToolbarCollapseButtonClicked()
97
fun onToolbarExpandButtonClicked()
108
fun onToolbarFormatButtonClicked(format: TextFormat, isKeyboardShortcut: Boolean)
119
fun onToolbarHeadingButtonClicked()
10+
fun onToolbarHtmlButtonClicked()
1211
fun onToolbarListButtonClicked()
12+
fun onToolbarMediaButtonClicked()
1313
}

0 commit comments

Comments
 (0)