Skip to content

Commit e578ad1

Browse files
committed
Deps: Replace android material with androidx appcompat in wordpress cmt
Removing the 'android.material' dependency wasn't enough by itself as the build was then failing. Adding the transient 'androidx.appcompat' dependency was actually required in order to make the build successful again. Then, and just like it was done on this (7db2a43) change, the seemingly unused 'androidx.appcompat' dependency advise got suppressed as well. ------------------------------------------------------------------------ This replacement was suggested by the dependency analysis report, see below: Advice for :wordpress-comments Unused dependencies which should be removed: implementation 'com.google.android.material:material:1.2.1'
1 parent 4c7a164 commit e578ad1

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

wordpress-comments/build.gradle

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,22 @@ android {
3838
dependencies {
3939
implementation aztecProjectDependency
4040

41-
implementation 'com.google.android.material:material:1.0.0'
41+
implementation 'androidx.appcompat:appcompat:1.0.0'
4242
implementation "org.wordpress:utils:$wordpressUtilsVersion"
4343

4444
testImplementation "junit:junit:$jUnitVersion"
4545
testImplementation "org.robolectric:robolectric:$robolectricVersion"
4646
}
4747

48+
dependencyAnalysis {
49+
issues {
50+
onUnusedDependencies {
51+
// This dependency is actually needed otherwise the build fails in multiple places.
52+
exclude("androidx.appcompat:appcompat")
53+
}
54+
}
55+
}
56+
4857
project.afterEvaluate {
4958
publishing {
5059
publications {

0 commit comments

Comments
 (0)