Skip to content

Commit f42061a

Browse files
authored
Merge pull request #701 from wordpress-mobile/issue/700-focus-on-html-switch
Don't steal focus on initial load of media
2 parents 9614558 + 1b70838 commit f42061a

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

aztec/src/main/kotlin/org/wordpress/aztec/AztecText.kt

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1025,7 +1025,7 @@ open class AztecText : AppCompatEditText, TextWatcher, UnknownHtmlSpan.OnUnknown
10251025
private fun replaceImage(drawable: Drawable?) {
10261026
it.drawable = drawable
10271027
post {
1028-
refreshText()
1028+
refreshText(false)
10291029
}
10301030
}
10311031
}
@@ -1058,7 +1058,7 @@ open class AztecText : AppCompatEditText, TextWatcher, UnknownHtmlSpan.OnUnknown
10581058
private fun replaceImage(drawable: Drawable?) {
10591059
it.drawable = drawable
10601060
post {
1061-
refreshText()
1061+
refreshText(false)
10621062
}
10631063
}
10641064
}
@@ -1246,10 +1246,16 @@ open class AztecText : AppCompatEditText, TextWatcher, UnknownHtmlSpan.OnUnknown
12461246
}
12471247

12481248
open fun refreshText() {
1249+
refreshText(true)
1250+
}
1251+
1252+
open fun refreshText(stealEditorFocus: Boolean) {
12491253
disableTextChangedListener()
12501254
val selStart = selectionStart
12511255
val selEnd = selectionEnd
1252-
setFocusOnParentView()
1256+
if (stealEditorFocus) {
1257+
setFocusOnParentView()
1258+
}
12531259
text = editableText
12541260
setSelection(selStart, selEnd)
12551261
enableTextChangedListener()

wordpress-shortcodes/src/main/java/org/wordpress/aztec/plugins/shortcodes/extensions/VideoPressExtensions.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ fun AztecText.updateVideoPressThumb(thumbURL: String, videoURL: String, videoPre
2424
}
2525
}
2626
post {
27-
refreshText()
27+
refreshText(false)
2828
}
2929
}
3030

@@ -41,4 +41,4 @@ fun AztecText.updateVideoPressThumb(thumbURL: String, videoURL: String, videoPre
4141
}
4242
}
4343
imageGetter?.loadImage(thumbURL, callbacks, this.maxImagesWidth, this.minImagesWidth)
44-
}
44+
}

0 commit comments

Comments
 (0)