Merge pull request #1281 from wordpress-mobile/issue/1189_invoke_should_change_text_in

Check with the delegate if changes are allowed when custom pastes happens.

Author: SergioEstevao

Aztec/Classes/Extensions/UITextView+Delegate.swift

@@ -12,4 +12,11 @@ extension UITextView {
         delegate?.textViewDidChange?(self)
         NotificationCenter.default.post(name: UITextView.textDidChangeNotification, object: self)
     }
+
+    final func shouldChangeText(in range: NSRange, with text:String) -> Bool {
+        guard let result = self.delegate?.textView?(self, shouldChangeTextIn: range, replacementText: text) else {
+            return true
+        }
+        return result
+    }
 }

Aztec/Classes/TextKit/TextViewPasteboardDelegate.swift

@@ -28,6 +28,9 @@ open class AztecTextViewPasteboardDelegate: TextViewPasteboardDelegate {
         let selectedRange = textView.selectedRange
 
         if selectedRange.length == 0 {
+            guard textView.shouldChangeText(in: selectedRange, with: url.absoluteString) else {
+                return true
+            }
             textView.setLink(url, title:url.absoluteString, inRange: selectedRange)
         } else {
             textView.setLink(url, inRange: selectedRange)
@@ -45,6 +48,10 @@ open class AztecTextViewPasteboardDelegate: TextViewPasteboardDelegate {
             textView.storage.htmlConverter.isSupported(html) else {
                 return false
         }
+        let string = textView.storage.htmlConverter.attributedString(from: html)
+        guard textView.shouldChangeText(in: textView.selectedRange, with: string.string) else {
+            return true
+        }
 
         textView.replace(textView.selectedRange, withHTML: html)
         return true
@@ -60,6 +67,11 @@ open class AztecTextViewPasteboardDelegate: TextViewPasteboardDelegate {
         }
         string.loadLazyAttachments()
         let selectedRange = textView.selectedRange
+
+        guard textView.shouldChangeText(in: selectedRange, with: string.string) else {
+            return true
+        }
+
         let storage = textView.storage
 
         let finalRange = NSRange(location: selectedRange.location, length: string.length)
@@ -105,6 +117,11 @@ open class AztecTextViewPasteboardDelegate: TextViewPasteboardDelegate {
         }
 
         let selectedRange = textView.selectedRange
+
+        guard textView.shouldChangeText(in: selectedRange, with: string.string) else {
+            return true
+        }
+
         let finalRange = NSRange(location: selectedRange.location, length: string.length)
         let originalText = textView.attributedText.attributedSubstring(from: selectedRange)
 
@@ -133,4 +150,5 @@ open class AztecTextViewPasteboardDelegate: TextViewPasteboardDelegate {
 
         return true
     }
+
 }

Example/Example/EditorDemoController.swift

@@ -534,6 +534,10 @@ extension EditorDemoController : UITextViewDelegate {
     func scrollViewDidScroll(_ scrollView: UIScrollView) {
         updateTitlePosition()
     }
+
+    func textView(_ textView: UITextView, shouldChangeTextIn range: NSRange, replacementText text: String) -> Bool {
+        return true
+    }
 }
 
 extension EditorDemoController : Aztec.TextViewFormattingDelegate {

WordPressEditor/WordPressEditor/Classes/Plugins/WordPressPlugin/Calypso/Embeds/WordPressPasteboardDelegate.swift

@@ -17,10 +17,11 @@ class WordPressTextViewPasteboardDelegate: AztecTextViewPasteboardDelegate {
         }
 
         let result = super.tryPastingString(in: textView)
-
-        // Bump the input to the next line – we need the embed link to be the only
-        // text on this line – otherwise it can't be autoconverted.
-        textView.insertText(String(.lineSeparator))
+        if result {
+            // Bump the input to the next line – we need the embed link to be the only
+            // text on this line – otherwise it can't be autoconverted.
+            textView.insertText(String(.lineSeparator))
+        }
 
         return result
     }