Use applicationNameForUserAgent instead of customUserAgent

Co-authored-by: dcalhoun <[email protected]>

Author: Copilot

ios/Sources/GutenbergKit/Sources/EditorViewController.swift

@@ -78,7 +78,7 @@ public final class EditorViewController: UIViewController, GutenbergEditorContro
 
         self.webView = GBWebView(frame: .zero, configuration: config)
         self.webView.scrollView.keyboardDismissMode = .interactive
-        self.webView.customUserAgent = GBWebView.createCustomUserAgent()
+        self.webView.applicationNameForUserAgent = "GutenbergKit/\(GBKVersion.version)"
 
         self.isWarmupMode = isWarmupMode
 

ios/Sources/GutenbergKit/Sources/GBWebView.swift

@@ -1,41 +1,6 @@
 import WebKit
 
 class GBWebView: WKWebView {
-    
-    /// Cached custom user agent to avoid repeated WebView instantiation
-    private static var cachedCustomUserAgent: String?
-    
-    /// Creates a custom user agent string by appending GutenbergKit identifier to the default user agent
-    /// The result is cached after the first call to avoid performance overhead
-    static func createCustomUserAgent() -> String {
-        // Return cached value if available
-        if let cached = cachedCustomUserAgent {
-            return cached
-        }
-        
-        // Get the default user agent by creating a temporary WKWebView
-        let webView = WKWebView()
-        var defaultUserAgent = ""
-        
-        // Use DispatchGroup for synchronous wait
-        // This is safe during view initialization as it's not on a critical path
-        let group = DispatchGroup()
-        group.enter()
-        
-        webView.evaluateJavaScript("navigator.userAgent") { result, error in
-            if let result = result as? String {
-                defaultUserAgent = result
-            }
-            group.leave()
-        }
-        
-        group.wait()
-        
-        // Cache and return the result
-        let customUserAgent = "\(defaultUserAgent) GutenbergKit/\(GBKVersion.version)"
-        cachedCustomUserAgent = customUserAgent
-        return customUserAgent
-    }
 
     #if canImport(UIKit)
     /// Disables the default bottom bar that competes with the Gutenberg inserter

ios/Sources/GutenbergKit/Sources/Views/HTMLPreview/HTMLWebViewRenderer.swift

@@ -94,7 +94,7 @@ final class HTMLWebViewRenderer {
             // Create web view with small initial frame for off-screen rendering
             // Frame will be adjusted per render based on viewport width and content height
             webView = WKWebView(frame: CGRect(x: 0, y: 0, width: 1200, height: 100), configuration: config)
-            webView.customUserAgent = GBWebView.createCustomUserAgent()
+            webView.applicationNameForUserAgent = "GutenbergKit/\(GBKVersion.version)"
 
             delegate = RenderDelegate()
             webView.navigationDelegate = delegate

ios/Tests/GutenbergKitTests/GBWebViewTests.swift

@@ -4,37 +4,23 @@ import WebKit
 
 final class GBWebViewTests: XCTestCase {
 
-    func testCreateCustomUserAgent() {
-        // When
-        let customUserAgent = GBWebView.createCustomUserAgent()
+    func testApplicationNameForUserAgent() {
+        // Given
+        let webView = GBWebView()
 
-        // Then
-        XCTAssertTrue(customUserAgent.contains("GutenbergKit/"), 
-                     "User agent should contain GutenbergKit identifier")
-        XCTAssertTrue(customUserAgent.contains("GutenbergKit/\(GBKVersion.version)"), 
-                     "User agent should contain version number")
-        XCTAssertTrue(customUserAgent.contains("Mozilla"), 
-                     "User agent should contain Mozilla identifier from default user agent")
-    }
-    
-    func testCustomUserAgentEndsWithGutenbergKitIdentifier() {
         // When
-        let customUserAgent = GBWebView.createCustomUserAgent()
+        webView.applicationNameForUserAgent = "GutenbergKit/\(GBKVersion.version)"
 
         // Then
-        XCTAssertTrue(customUserAgent.hasSuffix(" GutenbergKit/\(GBKVersion.version)"), 
-                     "Custom user agent should end with GutenbergKit identifier")
+        XCTAssertEqual(webView.applicationNameForUserAgent, "GutenbergKit/\(GBKVersion.version)",
+                      "Application name should be set correctly")
     }
 
-    func testCustomUserAgentIsConsistent() {
-        // Given
-        let firstCall = GBWebView.createCustomUserAgent()
-        
-        // When
-        let secondCall = GBWebView.createCustomUserAgent()
-        
+    func testVersionConstantExists() {
         // Then
-        XCTAssertEqual(firstCall, secondCall, 
-                      "Custom user agent should be consistent across calls")
+        XCTAssertFalse(GBKVersion.version.isEmpty,
+                      "Version constant should not be empty")
+        XCTAssertTrue(GBKVersion.version.contains("."),
+                     "Version should be in semantic versioning format")
     }
 }