CMM 735 enable application password feature when the user accepts to use a feature that must include it (#22195)

* feat: Gate GutenbergKit with app password

An application password is necessary for sites without a Jetpack
connection, otherwise REST API requests fail, as GutenbergKit does not
support cookie authentication.

* style: Disable return count warning

Postpone larger refactors as technical debt.

* Enable feature is necessary

* Adding an extra note

* Fixing tests

---------

Co-authored-by: David Calhoun <[email protected]>

Author: adalpari

WordPress/src/main/java/org/wordpress/android/ui/accounts/login/applicationpassword/ApplicationPasswordDialogViewModel.kt

@@ -12,13 +12,16 @@ import kotlinx.coroutines.flow.asStateFlow
 import kotlinx.coroutines.launch
 import org.wordpress.android.fluxc.utils.AppLogWrapper
 import org.wordpress.android.ui.accounts.login.ApplicationPasswordLoginHelper
+import org.wordpress.android.ui.prefs.experimentalfeatures.ExperimentalFeatures
+import org.wordpress.android.ui.prefs.experimentalfeatures.ExperimentalFeatures.Feature
 import org.wordpress.android.util.AppLog
 import javax.inject.Inject
 
 @HiltViewModel
 class ApplicationPasswordDialogViewModel @Inject constructor(
     private val applicationPasswordLoginHelper: ApplicationPasswordLoginHelper,
     private val appLogWrapper: AppLogWrapper,
+    private val experimentalFeatures: ExperimentalFeatures,
 ) : ViewModel() {
     private val _navigationEvent = MutableSharedFlow<NavigationEvent>()
     val navigationEvent: SharedFlow<NavigationEvent> = _navigationEvent.asSharedFlow()
@@ -38,6 +41,8 @@ class ApplicationPasswordDialogViewModel @Inject constructor(
             }
 
             try {
+                // Assume that the Application Password experimental feature can be enabled
+                enableApplicationPasswordIfNecessary()
                 val completeAuthUrl = applicationPasswordLoginHelper.getAuthorizationUrlComplete(authenticationUrl)
 
                 if (completeAuthUrl.isNotEmpty()) {
@@ -55,6 +60,12 @@ class ApplicationPasswordDialogViewModel @Inject constructor(
         }
     }
 
+    private fun enableApplicationPasswordIfNecessary() {
+        if (!experimentalFeatures.isEnabled(Feature.EXPERIMENTAL_APPLICATION_PASSWORD_FEATURE)) {
+            experimentalFeatures.setEnabled(Feature.EXPERIMENTAL_APPLICATION_PASSWORD_FEATURE, true)
+        }
+    }
+
     sealed class NavigationEvent {
         data class NavigateToLogin(val authenticationUrl: String) : NavigationEvent()
         object ShowError : NavigationEvent()

WordPress/src/main/java/org/wordpress/android/ui/accounts/login/applicationpassword/ApplicationPasswordRequiredDialogActivity.kt

@@ -6,10 +6,13 @@ import org.wordpress.android.R
 @AndroidEntryPoint
 class ApplicationPasswordRequiredDialogActivity : ApplicationPasswordDialogActivity() {
     override fun getTitleResource(): Int = R.string.application_password_required
-    override fun getDescriptionString(): String =
-        intent.getStringExtra(EXTRA_FEATURE_NAME)?.let {
+    override fun getDescriptionString(): String {
+        val baseDescription = intent.getStringExtra(EXTRA_FEATURE_NAME)?.let {
             resources.getString(R.string.application_password_required_description, it)
-        } ?: resources.getString(R.string.application_password_required_description_default)
+        } ?: resources.getString(R.string.application_password_info_description_1)
+
+        return baseDescription + resources.getString(R.string.application_password_experimental_feature_note)
+    }
     override fun getButtonTextResource(): Int = R.string.get_started
 
     companion object {

WordPress/src/main/res/values/strings.xml

@@ -5062,7 +5062,7 @@ translators: %s: Select control option value e.g: "Auto, 25%". -->
     <string name="application_password_required">Application Password Required</string>
     <string name="application_password_required_description">Application passwords are a more secure way to connect to your self-hosted site, and enable support for features like %1$s.</string>
     <string name="application_password_required_block_editor">Block Editor</string>
-    <string name="application_password_required_description_default">Application passwords are a more secure way to connect to your self-hosted site, and enable new features support.</string>
+    <string name="application_password_experimental_feature_note">\n\nNote: Application Password authentication on Android devices is an Experimental Feature.</string>
     <string name="application_password_disable_feature_title">Disable Application Password?</string>
     <string name="application_password_disable_feature_description">Disabling Application Password will remove the login for %1$s of your sites. You may need to re-add affected sites to login again.</string>
     <string name="application_password_info_title">Application Passwords</string>

WordPress/src/test/java/org/wordpress/android/ui/accounts/login/applicationpassword/ApplicationPasswordDialogViewModelTest.kt

@@ -16,6 +16,7 @@ import org.mockito.kotlin.whenever
 import org.wordpress.android.BaseUnitTest
 import org.wordpress.android.fluxc.utils.AppLogWrapper
 import org.wordpress.android.ui.accounts.login.ApplicationPasswordLoginHelper
+import org.wordpress.android.ui.prefs.experimentalfeatures.ExperimentalFeatures
 import kotlin.test.assertEquals
 import kotlin.test.assertFalse
 import kotlin.test.assertTrue
@@ -28,6 +29,9 @@ class ApplicationPasswordDialogViewModelTest : BaseUnitTest() {
     @Mock
     lateinit var appLogWrapper: AppLogWrapper
 
+    @Mock
+    lateinit var experimentalFeatures: ExperimentalFeatures
+
     private lateinit var viewModel: ApplicationPasswordDialogViewModel
 
     private val testAuthUrl = "https://example.com/wp-admin/authorize-application.php"
@@ -39,7 +43,8 @@ class ApplicationPasswordDialogViewModelTest : BaseUnitTest() {
         MockitoAnnotations.openMocks(this)
         viewModel = ApplicationPasswordDialogViewModel(
             applicationPasswordLoginHelper,
-            appLogWrapper
+            appLogWrapper,
+            experimentalFeatures
         )
     }