CMM-1037 NotificationsListFragmentPage empty view (#22509)

* Added test code with TODO

* Remove illustration from notifications empty view

Hide the image in the empty view regardless of device orientation.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Remove illustration from notifications empty view XML layout

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Remove redundant image visibility code from NotificationsListFragmentPage

The image visibility line is no longer needed since the image was removed
from the XML layout. Also removes the unused DisplayUtils import.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Updated notifs empty view strings

* Add bottom padding to center empty view vertically

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Removed TODO

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Author: nbradbury

WordPress/src/main/java/org/wordpress/android/ui/notifications/NotificationsListFragmentPage.kt

@@ -67,7 +67,6 @@ import org.wordpress.android.ui.reader.comments.ThreadedCommentsActionSource
 import org.wordpress.android.util.AniUtils
 import org.wordpress.android.util.AppLog
 import org.wordpress.android.util.AppLog.T
-import org.wordpress.android.util.DisplayUtils
 import org.wordpress.android.util.NetworkUtils
 import org.wordpress.android.util.WPSwipeToRefreshHelper
 import org.wordpress.android.util.analytics.AnalyticsTrackerWrapper
@@ -126,8 +125,8 @@ class NotificationsListFragmentPage : ViewPagerFragment(R.layout.notifications_l
         }
         notesAdapter = NotesAdapter(requireActivity(), inlineActionEvents = viewModel.inlineActionEvents).apply {
             onNoteClicked = { noteId -> handleNoteClick(noteId) }
-            onNotesLoaded = {
-                itemCount -> updateEmptyLayouts(itemCount)
+            onNotesLoaded = { _ ->
+                updateEmptyLayouts(itemCount)
                 swipeToRefreshHelper?.isRefreshing = false
             }
             viewModel.inlineActionEvents.flowWithLifecycle(viewLifecycleOwner.lifecycle, Lifecycle.State.STARTED)
@@ -394,7 +393,6 @@ class NotificationsListFragmentPage : ViewPagerFragment(R.layout.notifications_l
         } else {
             showEmptyView(titleResId)
         }
-        actionableEmptyView.image.visibility = if (DisplayUtils.isLandscape(context)) View.GONE else View.VISIBLE
     }
 
     private fun NotificationsListFragmentPageBinding.showNewNotificationsBar() {

WordPress/src/main/res/layout/notifications_list_fragment_page.xml

@@ -31,9 +31,9 @@
         android:id="@+id/actionable_empty_view"
         android:layout_height="match_parent"
         android:layout_width="match_parent"
+        android:paddingBottom="?attr/actionBarSize"
         android:visibility="gone"
         app:aevButton="@string/posts_empty_list_button"
-        app:aevImage="@drawable/img_illustration_notifications_152dp"
         app:aevSubtitle="@string/notifications_empty_action_unread"
         app:aevTitle="@string/notifications_empty_unread"
         tools:visibility="visible">

WordPress/src/main/res/values/strings.xml

@@ -1583,15 +1583,15 @@
     <string name="new_notifications">%d new notifications</string>
     <string name="more_notifications">and %d more.</string>
     <string name="notifications_empty_list">No notifications</string>
-    <string name="notifications_empty_all">No notifications…yet.</string>
+    <string name="notifications_empty_all">No notifications…yet!</string>
     <string name="notifications_empty_unread">You\'re all up to date!</string>
     <string name="notifications_empty_comments">No comments yet</string>
     <string name="notifications_empty_subscribers">No subscribers yet</string>
     <string name="notifications_empty_likes">No likes yet</string>
-    <string name="notifications_empty_action_all">Get active! Comment on posts from blogs you follow.</string>
-    <string name="notifications_empty_action_unread">Reignite the conversation: write a new post</string>
-    <string name="notifications_empty_action_comments">Join a conversation: comment on posts from blogs you follow</string>
-    <string name="notifications_empty_action_followers_likes">Get noticed: comment on posts you\'ve read</string>
+    <string name="notifications_empty_action_all">Get active! Comment on posts in the Reader.</string>
+    <string name="notifications_empty_action_unread">Reignite the conversation! Write a new post.</string>
+    <string name="notifications_empty_action_comments">Join a conversation! Comment on posts in the Reader.</string>
+    <string name="notifications_empty_action_followers_likes">Get noticed! Comment on posts you\'ve read.</string>
     <string name="notifications_jetpack_connection_setup_info">To get helpful notifications on your device from your WordPress site, you\'ll need to install the Jetpack plugin. Would you like to set up Jetpack?</string>
     <string name="notifications_empty_view_reader">Go to Reader</string>
     <string name="content_description_person_reading_device_notification">Person reading device with notifications</string>