Skip to content

Updated bookmark icon to be more visible in dark mode #22399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nbradbury wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Updated bookmark icon to be more visible in dark mode #22399

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41b6812
Updated bookmark icon to be more visible in dark mode
nbradbury Dec 4, 2025
1af6db2
Use a const for the alpha
nbradbury Dec 4, 2025
6e108a5
Merge branch 'trunk' into issue/CMM-1043-bookmark-icon-tint
nbradbury Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import androidx.core.view.isVisible
import androidx.lifecycle.ViewModelProvider
import androidx.lifecycle.lifecycleScope
import androidx.recyclerview.widget.RecyclerView
import com.google.android.material.R as MaterialR
import com.google.android.material.dialog.MaterialAlertDialogBuilder
import com.google.android.material.snackbar.Snackbar
import com.google.android.material.tabs.TabLayout
Expand Down Expand Up @@ -143,6 +144,7 @@ import org.wordpress.android.util.StringUtils
import org.wordpress.android.util.ToastUtils
import org.wordpress.android.util.WPActivityUtils
import org.wordpress.android.util.config.SeenUnseenWithCounterFeatureConfig
import org.wordpress.android.util.extensions.getColorFromAttribute
import org.wordpress.android.util.image.ImageManager
import org.wordpress.android.viewmodel.Event
import org.wordpress.android.widgets.AppReviewManager.incrementInteractions
Expand Down Expand Up @@ -1849,6 +1851,11 @@ class ReaderPostListFragment : ViewPagerFragment(), OnPostSelectedListener, OnFo
requireContext(),
R.drawable.ic_bookmark_grey_dark_18dp
)

val tint = requireContext().getColorFromAttribute(MaterialR.attr.colorOnBackground)
drawable?.setTint(tint)
drawable?.alpha = BOOKMARK_IMAGE_ALPHA

drawable!!.setBounds(
0,
0,
Expand Down Expand Up @@ -2902,6 +2909,7 @@ class ReaderPostListFragment : ViewPagerFragment(), OnPostSelectedListener, OnFo
private const val NO_POSITION = -1
private const val RECYCLER_DELAY_MS = 1000L
private const val BOOKMARK_IMAGE_MULTIPLIER = 1.2
private const val BOOKMARK_IMAGE_ALPHA = 150
private var hasPurgedReaderDb = false

/*
Expand Down