Skip to content

Commit 0ea3205

Browse files
authored
feat: Improve editor session events (#23955)
* feat: Introduce `gutenberg_kit` editor session event property value Denote sessions utilizing the GutenbergKit editor. * feat: Track editor session start event Enable more robust editor session analysis. * build: Update GutenbergKit ref * build: Update GutenbergKit ref
1 parent 8415756 commit 0ea3205

File tree

4 files changed

+15
-5
lines changed

4 files changed

+15
-5
lines changed

Modules/Package.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ let package = Package(
4848
.package(url: "https://github.com/zendesk/support_sdk_ios", from: "8.0.3"),
4949
// We can't use wordpress-rs branches nor commits here. Only tags work.
5050
.package(url: "https://github.com/Automattic/wordpress-rs", revision: "alpha-20241116"),
51-
.package(url: "https://github.com/wordpress-mobile/GutenbergKit", revision: "v0.0.3"),
51+
.package(url: "https://github.com/wordpress-mobile/GutenbergKit", revision: "4476d597b271778d001a26c50d74e527b54ebfef"),
5252
.package(url: "https://github.com/Automattic/color-studio", branch: "trunk"),
5353
],
5454
targets: XcodeSupport.targets + [

WordPress.xcworkspace/xcshareddata/swiftpm/Package.resolved

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

WordPress/Classes/ViewRelated/NewGutenberg/NewGutenbergViewController.swift

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ class NewGutenbergViewController: UIViewController, PostEditor, PublishingEditor
127127
self.post = post
128128

129129
self.replaceEditor = replaceEditor
130-
self.editorSession = PostEditorAnalyticsSession(editor: .gutenberg, post: post)
130+
self.editorSession = PostEditorAnalyticsSession(editor: .gutenbergKit, post: post)
131131
self.navigationBarManager = navigationBarManager ?? PostEditorNavigationBarManager()
132132

133133
let networkClient = NewGutenbergNetworkClient(blog: post.blog)
@@ -315,6 +315,16 @@ class NewGutenbergViewController: UIViewController, PostEditor, PublishingEditor
315315
}
316316

317317
extension NewGutenbergViewController: GutenbergKit.EditorViewControllerDelegate {
318+
func editorDidLoad(_ viewContoller: GutenbergKit.EditorViewController) {
319+
if !editorSession.started {
320+
// Note that this method is also used to track startup performance
321+
// It assumes this is being called when the editor has finished loading
322+
// If you need to refactor this, please ensure that the startup_time_ms property
323+
// is still reflecting the actual startup time of the editor
324+
editorSession.start()
325+
}
326+
}
327+
318328
func editor(_ viewContoller: GutenbergKit.EditorViewController, didDisplayInitialContent content: String) {
319329
// Do nothing
320330
}

WordPress/Classes/ViewRelated/Post/PostEditorAnalyticsSession.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ private extension PostEditorAnalyticsSession {
9797
extension PostEditorAnalyticsSession {
9898
enum Editor: String {
9999
case gutenberg
100+
case gutenbergKit = "gutenberg_kit"
100101
case classic
101102
case html
102103
}

0 commit comments

Comments
 (0)