Skip to content

Commit 9dca141

Browse files
Refactor: move max number of lines to a constant variable
1 parent 4ebe08b commit 9dca141

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

WordPress/Classes/ViewRelated/Jetpack/Branding/Fullscreen Overlay/JetpackFullscreenOverlayGeneralViewModel.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ struct JetpackFullscreenOverlayGeneralViewModel: JetpackFullscreenOverlayViewMod
161161
}
162162

163163
var titleLabelMaxNumberOfLines: Int {
164-
return 2
164+
return Constants.titleLabelMaxNumberOfLines
165165
}
166166

167167
var onDismiss: JetpackOverlayDismissCallback?
@@ -175,6 +175,7 @@ private extension JetpackFullscreenOverlayGeneralViewModel {
175175
static let readerLogoAnimationRtl = "JetpackReaderLogoAnimation_rtl"
176176
static let notificationsLogoAnimationLtr = "JetpackNotificationsLogoAnimation_ltr"
177177
static let notificationsLogoAnimationRtl = "JetpackNotificationsLogoAnimation_rtl"
178+
static let titleLabelMaxNumberOfLines: Int = 2
178179
}
179180

180181
enum Strings {

WordPress/Classes/ViewRelated/Jetpack/Branding/Fullscreen Overlay/JetpackFullscreenOverlaySiteCreationViewModel.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ struct JetpackFullscreenOverlaySiteCreationViewModel: JetpackFullscreenOverlayVi
7171
}
7272

7373
var titleLabelMaxNumberOfLines: Int {
74-
return 3
74+
return Constants.titleLabelMaxNumberOfLines
7575
}
7676

7777
var onDismiss: JetpackOverlayDismissCallback?
@@ -82,6 +82,7 @@ private extension JetpackFullscreenOverlaySiteCreationViewModel {
8282
static let wpJetpackLogoAnimationLtr = "JetpackWordPressLogoAnimation_ltr"
8383
static let wpJetpackLogoAnimationRtl = "JetpackWordPressLogoAnimation_rtl"
8484
static let analyticsSource = "site_creation"
85+
static let titleLabelMaxNumberOfLines: Int = 3
8586
}
8687

8788
enum Strings {

0 commit comments

Comments
 (0)