Collapse multiple spaces in site titles into one (#25094)

kean · web-flow · commit d76ee0659e0e · 2026-01-08T16:46:03.000Z
* Collapse multiple spaces in site titles into one

* Update based on comments

* Fix typo
diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt
@@ -5,11 +5,11 @@
 * [*] Reader: Keep only one "Search" option in the main sidebar [#25116]
 * [*] Reader: Fix Send button design in Comments [#25092]
 * [*] Reader: Add translation support for posts [#25089]
+* [*] Reader: Collapse multiple spaces in site titles into one [#25094]
 * [*] Fix previewing posts on WordPress.com atomic sites [#25045]
 * [*] Stats: Rename "External Links" to "Clicks" to be consistent with the web [#25090]
 * [*] Stats: Fix locations data discrepancy with the web [#25105]
 
-
 26.5
 -----
 * [*] Add "Status" field to the "Post Settings" screen to make it easier to move posts from one state to another [#24939]
diff --git a/Sources/WordPressData/Swift/ReaderPost.swift b/Sources/WordPressData/Swift/ReaderPost.swift
@@ -52,7 +52,7 @@ extension ReaderPost {
 
     public func blogNameForDisplay() -> String? {
         if let blogName, !blogName.isEmpty {
-            return blogName
+            return blogName.replacing(/\s+/, with: " ")
         }
         return URL(string: blogURL ?? "")?.host
     }
diff --git a/Tests/KeystoneTests/Tests/Models/ReaderPostTests.swift b/Tests/KeystoneTests/Tests/Models/ReaderPostTests.swift
@@ -20,4 +20,10 @@ final class ReaderPostTests: CoreDataTestCase {
         XCTAssertEqual(queryItems.first(where: { $0.name == "s" })?.value, Int(50 * UITraitCollection.current.displayScale).description)
         XCTAssertEqual(queryItems.first(where: { $0.name == "d" })?.value, "404")
     }
+
+    func testBlogNameForDisplay() {
+        let post = NSEntityDescription.insertNewObject(forEntityName: ReaderPost.entityName(), into: mainContext) as! ReaderPost
+        post.blogName = "t          r          e          f          o          l          o          g          y"
+        XCTAssertEqual(post.blogNameForDisplay(), "t r e f o l o g y")
+    }
 }
diff --git a/WordPress/Classes/ViewRelated/Reader/Controllers/ReaderFeedCell.swift b/WordPress/Classes/ViewRelated/Reader/Controllers/ReaderFeedCell.swift
@@ -43,7 +43,7 @@ struct ReaderFeedCell: View {
 
     var title: String {
         if let title = feed.title?.stringByDecodingXMLCharacters(), !title.isEmpty {
-            return title
+            return title.replacing(/\s+/) { _ in " " }
         }
         return feed.urlForDisplay ?? "–"
     }
diff --git a/WordPress/Classes/ViewRelated/Reader/Headers/ReaderSiteHeaderView.swift b/WordPress/Classes/ViewRelated/Reader/Headers/ReaderSiteHeaderView.swift
@@ -34,7 +34,7 @@ class ReaderSiteHeaderView: ReaderBaseHeaderView, ReaderStreamHeader {
             return
         }
         headerViewModel.site = siteTopic
-        headerViewModel.title = siteTopic.title
+        headerViewModel.title = siteTopic.title.replacing(/\s+/) { _ in " " }
         headerViewModel.siteUrl = URL(string: siteTopic.siteURL)?.host ?? ""
         headerViewModel.siteDetails = siteTopic.siteDescription
         headerViewModel.postCount = siteTopic.postCount.doubleValue.abbreviatedString()

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ extension ReaderPost {`
`52`	`52`
`53`	`53`	`public func blogNameForDisplay() -> String? {`
`54`	`54`	`if let blogName, !blogName.isEmpty {`
`55`		`- return blogName`
	`55`	`+ return blogName.replacing(/\s+/, with: " ")`
`56`	`56`	`}`
`57`	`57`	`return URL(string: blogURL ?? "")?.host`
`58`	`58`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,4 +20,10 @@ final class ReaderPostTests: CoreDataTestCase {`
`20`	`20`	`XCTAssertEqual(queryItems.first(where: { $0.name == "s" })?.value, Int(50 * UITraitCollection.current.displayScale).description)`
`21`	`21`	`XCTAssertEqual(queryItems.first(where: { $0.name == "d" })?.value, "404")`
`22`	`22`	`}`
	`23`	`+`
	`24`	`+ func testBlogNameForDisplay() {`
	`25`	`+ let post = NSEntityDescription.insertNewObject(forEntityName: ReaderPost.entityName(), into: mainContext) as! ReaderPost`
	`26`	`+ post.blogName = "t r e f o l o g y"`
	`27`	`+ XCTAssertEqual(post.blogNameForDisplay(), "t r e f o l o g y")`
	`28`	`+ }`
`23`	`29`	`}`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ struct ReaderFeedCell: View {`
`43`	`43`
`44`	`44`	`var title: String {`
`45`	`45`	`if let title = feed.title?.stringByDecodingXMLCharacters(), !title.isEmpty {`
`46`		`- return title`
	`46`	`+ return title.replacing(/\s+/) { _ in " " }`
`47`	`47`	`}`
`48`	`48`	`return feed.urlForDisplay ?? "–"`
`49`	`49`	`}`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ class ReaderSiteHeaderView: ReaderBaseHeaderView, ReaderStreamHeader {`
`34`	`34`	`return`
`35`	`35`	`}`
`36`	`36`	`headerViewModel.site = siteTopic`
`37`		`- headerViewModel.title = siteTopic.title`
	`37`	`+ headerViewModel.title = siteTopic.title.replacing(/\s+/) { _ in " " }`
`38`	`38`	`headerViewModel.siteUrl = URL(string: siteTopic.siteURL)?.host ?? ""`
`39`	`39`	`headerViewModel.siteDetails = siteTopic.siteDescription`
`40`	`40`	`headerViewModel.postCount = siteTopic.postCount.doubleValue.abbreviatedString()`