Skip to content

Commit ed3a360

Browse files
authored
Fix an NSLocalizedStrings not using a literal value (#19606)
2 parents e47325f + 9249225 commit ed3a360

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

WordPress/Jetpack/Classes/ViewRelated/WordPress-to-Jetpack Migration/Common/Views/Configuration/MigrationHeaderConfiguration.swift

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -101,14 +101,18 @@ private extension MigrationHeaderConfiguration {
101101
comment: "Secondary description in the migration notifications screen")
102102

103103
static func welcomeSecondaryDescription(plural: Bool) -> String {
104-
let siteWord = plural ? "sites" : "site"
105-
let value = "We found your \(siteWord). Continue to transfer all your data and sign in to Jetpack automatically."
106104
if plural {
107-
let comment = "The plural form of the secondary description in the migration welcome screen"
108-
return NSLocalizedString("migration.welcome.secondaryDescription.plural", value: value, comment: comment)
105+
return NSLocalizedString(
106+
"migration.welcome.secondaryDescription.plural",
107+
value: "We found your sites. Continue to transfer all your data and sign in to Jetpack automatically.",
108+
comment: "The plural form of the secondary description in the migration welcome screen"
109+
)
109110
} else {
110-
let comment = "The singular form of the secondary description in the migration welcome screen"
111-
return NSLocalizedString("migration.welcome.secondaryDescription.singular", value: value, comment: comment)
111+
return NSLocalizedString(
112+
"migration.welcome.secondaryDescription.singular",
113+
value: "We found your site. Continue to transfer all your data and sign in to Jetpack automatically.",
114+
comment: "The singular form of the secondary description in the migration welcome screen"
115+
)
112116
}
113117
}
114118
}

WordPress/Resources/en.lproj/Localizable.strings

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4818,11 +4818,11 @@
48184818
/* The primary description in the migration welcome screen */
48194819
"migration.welcome.primaryDescription" = "It looks like you’re switching from the WordPress app.";
48204820

4821-
/* No comment provided by engineer. */
4822-
"migration.welcome.secondaryDescription.plural" = "migration.welcome.secondaryDescription.plural";
4821+
/* The plural form of the secondary description in the migration welcome screen */
4822+
"migration.welcome.secondaryDescription.plural" = "We found your sites. Continue to transfer all your data and sign in to Jetpack automatically.";
48234823

4824-
/* No comment provided by engineer. */
4825-
"migration.welcome.secondaryDescription.singular" = "migration.welcome.secondaryDescription.singular";
4824+
/* The singular form of the secondary description in the migration welcome screen */
4825+
"migration.welcome.secondaryDescription.singular" = "We found your site. Continue to transfer all your data and sign in to Jetpack automatically.";
48264826

48274827
/* The title in the migration welcome screen */
48284828
"migration.welcome.title" = "Welcome to Jetpack!";

0 commit comments

Comments
 (0)