Move hardcoded deep link schemes to AppConstant

Author: dvdchr

WordPress/Classes/Utility/App Configuration/AppConstants.swift

@@ -27,6 +27,20 @@ import WordPressAuthenticator
     #endif
     #endif
     #endif
+
+    /// Deep Link URL Scheme
+    ///
+    /// Note: This needs to be manually in sync with Target > Build Settings > User-defined > `WPCOM_SCHEME`.
+    ///
+    #if DEBUG
+    static let deepLinkScheme = "wpdebug"
+    #elseif INTERNAL_BUILD
+    static let deepLinkScheme = "wpinternal"
+    #elseif ALPHA_BUILD
+    static let deepLinkScheme = "wpalpha"
+    #else
+    static let deepLinkScheme = "wordpress"
+    #endif
 }
 
 // MARK: - Tab bar order

WordPress/Classes/ViewRelated/Jetpack/Branding/Coordinator/JetpackBrandingCoordinator.swift

@@ -6,18 +6,7 @@ class JetpackBrandingCoordinator {
     static func presentOverlay(from viewController: UIViewController, redirectAction: (() -> Void)? = nil) {
 
         let action = redirectAction ?? {
-            #if DEBUG
-            let jetpackScheme = "jpdebug"
-            #elseif INTERNAL_BUILD
-            let jetpackScheme = "jpinternal"
-            #elseif ALPHA_BUILD
-            let jetpackScheme = "jpalpha"
-            #else
-            let jetpackScheme = "jetpack"
-            #endif
-
-            guard AppConfiguration.isWordPress,
-                  let jetpackDeepLinkURL = URL(string: "\(jetpackScheme)://app"),
+            guard let jetpackDeepLinkURL = URL(string: "\(AppConstants.deepLinkScheme)://app"),
                   let jetpackUniversalLinkURL = URL(string: "https://jetpack.com/app"),
                   let jetpackAppStoreURL = URL(string: "https://apps.apple.com/app/jetpack-website-builder/id1565481562") else {
                 return

WordPress/Jetpack/AppConstants.swift

@@ -27,6 +27,20 @@ import WordPressKit
     #endif
     #endif
     #endif
+
+    /// Deep Link URL Scheme
+    ///
+    /// Note: this needs to be in sync with Target > Build Settings > User-defined > `WPCOM_SCHEME` value.
+    ///
+    #if DEBUG
+    static let deepLinkScheme = "jpdebug"
+    #elseif INTERNAL_BUILD
+    static let deepLinkScheme = "jpinternal"
+    #elseif ALPHA_BUILD
+    static let deepLinkScheme = "jpalpha"
+    #else
+    static let deepLinkScheme = "jetpack"
+    #endif
 }
 
 // MARK: - Tab bar order