[Jetpack Content Migration] Notification and Success screens UI Tweaks (#19632)

Author: salimbraksa

WordPress/Jetpack/Classes/ViewRelated/WordPress-to-Jetpack Migration/All done/MigrationDoneViewController.swift

@@ -22,4 +22,14 @@ class MigrationDoneViewController: UIViewController {
                                  actionsView: MigrationActionsView(configuration: viewModel.configuration.actionsConfiguration),
                                  centerView: centerView)
     }
+
+    override func viewWillAppear(_ animated: Bool) {
+        super.viewWillAppear(animated)
+        self.navigationController?.setNavigationBarHidden(true, animated: animated)
+    }
+
+    override func viewWillDisappear(_ animated: Bool) {
+        super.viewWillDisappear(animated)
+        self.navigationController?.setNavigationBarHidden(false, animated: animated)
+    }
 }

WordPress/Jetpack/Classes/ViewRelated/WordPress-to-Jetpack Migration/Common/Views/MigrationActionsView.swift

@@ -102,8 +102,9 @@ final class MigrationActionsView: UIView {
 
     private static func secondaryButton() -> UIButton {
         let button = UIButton()
-        let font = WPStyleGuide.fontForTextStyle(.headline)
-        button.setTitleColor(.text, for: .normal)
+        let font = Constants.secondaryButtonFont
+        let color = Constants.secondaryButtonColor
+        button.setTitleColor(color, for: .normal)
         button.titleLabel?.font = font
         button.titleLabel?.adjustsFontForContentSizeCategory = true
         return button
@@ -121,5 +122,7 @@ final class MigrationActionsView: UIView {
         static let separatorHeight = CGFloat(0.5)
         static let insets = NSDirectionalEdgeInsets(top: 20, leading: 30, bottom: 20, trailing: 30)
         static let spacing = CGFloat(10)
+        static let secondaryButtonFont = WPStyleGuide.fontForTextStyle(.headline, fontWeight: .regular)
+        static let secondaryButtonColor = UIColor.muriel(color: .jetpackGreen, .shade50)
     }
 }

WordPress/Jetpack/Classes/ViewRelated/WordPress-to-Jetpack Migration/Common/Views/MigrationCenterView.swift

@@ -13,8 +13,10 @@ class MigrationCenterView: UIView {
         if let configuration {
             label.attributedText = configuration.attributedText
         }
+        label.textAlignment = .center
         label.textColor = Appearance.descriptionTextColor
         label.numberOfLines = 0
+        label.adjustsFontForContentSizeCategory = true
         return label
     }()
 

WordPress/Jetpack/Classes/ViewRelated/WordPress-to-Jetpack Migration/Common/Views/MigrationStepView.swift

@@ -54,7 +54,14 @@ class MigrationStepView: UIView {
     private func activateConstraints() {
         centerContentView.pinSubviewToAllEdges(centerView, insets: Constants.centerContentMargins)
         contentView.pinSubviewToAllEdges(mainStackView)
-        pinSubviewToAllEdges(mainScrollView)
+
+        NSLayoutConstraint.activate([
+            mainScrollView.topAnchor.constraint(equalTo: safeAreaLayoutGuide.topAnchor),
+            mainScrollView.leadingAnchor.constraint(equalTo: leadingAnchor),
+            mainScrollView.trailingAnchor.constraint(equalTo: trailingAnchor),
+            mainScrollView.bottomAnchor.constraint(equalTo: bottomAnchor),
+        ])
+
         mainScrollView.pinSubviewToAllEdges(contentView)
 
         NSLayoutConstraint.activate([
@@ -71,13 +78,24 @@ class MigrationStepView: UIView {
 
     override func layoutSubviews() {
         super.layoutSubviews()
-        mainScrollView.contentInset.bottom = actionsView.frame.size.height + Constants.bottomMargin
+        let bottomInset = actionsView.frame.size.height - safeAreaInsets.bottom
+        mainScrollView.contentInset.bottom = bottomInset + Constants.additionalBottomContentInset
+        mainScrollView.verticalScrollIndicatorInsets.bottom = bottomInset
+        mainScrollView.contentInset.top = Constants.topContentInset
     }
 
     private enum Constants {
+        /// Adds space between the content bottom edge and actions sheet top edge.
+        ///
+        /// Bottom inset is added to the `scrollView` so the content is not covered by the Actions Sheet view.
+        /// The value of the bottom inset is computed in `layoutSubviews`.
+        static let additionalBottomContentInset: CGFloat = 10
+
+        /// Adds top padding to the `scrollView`.
+        static let topContentInset: CGFloat = UINavigationBar().intrinsicContentSize.height
+
         static let centerContentMargins = UIEdgeInsets(top: 0, left: 30, bottom: 0, right: 30)
         static let stackViewSpacing: CGFloat = 20
-        static let bottomMargin: CGFloat = 20
         static let headerViewMargins = NSDirectionalEdgeInsets(top: 0, leading: 30, bottom: 0, trailing: 30)
     }
 }

WordPress/Jetpack/Classes/ViewRelated/WordPress-to-Jetpack Migration/Notifications Permission/MigrationNotificationsViewController.swift

@@ -21,5 +21,16 @@ class MigrationNotificationsViewController: UIViewController {
         view = MigrationStepView(headerView: MigrationHeaderView(configuration: viewModel.configuration.headerConfiguration),
                                  actionsView: MigrationActionsView(configuration: viewModel.configuration.actionsConfiguration),
                                  centerView: centerView)
+
+    }
+
+    override func viewWillAppear(_ animated: Bool) {
+        super.viewWillAppear(animated)
+        self.navigationController?.setNavigationBarHidden(true, animated: animated)
+    }
+
+    override func viewWillDisappear(_ animated: Bool) {
+        super.viewWillDisappear(animated)
+        self.navigationController?.setNavigationBarHidden(false, animated: animated)
     }
 }