Clobber all migrations mappings and policies — Very old (#24208)

* Clobber all migrations mappings and policies — Very old

For the sake of convenience and code maintenance, we decided to remove
these migrations because we consider it safe to assume all existing
users are on later versions. If no user will ever run the migrations,
the code is essentially dead code that we can remove.

For reference, the current version is 154 and the oldest migration was
91-to-92. The model version 92 dates back to 2019, see
dcdba23

* Move a few more utils types to WordPressShared (#24210)

- KeychainUtils & co
- UserPersistentRepository & co
- LocalFileStore & co

Author: mokagio

Modules/Package.swift

@@ -83,7 +83,15 @@ let package = Package(
         .target(name: "WordPressFlux", swiftSettings: [.swiftLanguageMode(.v5)]),
         .target(name: "WordPressCore", dependencies: [.target(name: "WordPressShared"), .product(name: "WordPressAPI", package: "wordpress-rs")]),
         .target(name: "WordPressSharedObjC", resources: [.process("Resources")], swiftSettings: [.swiftLanguageMode(.v5)]),
-        .target(name: "WordPressShared", dependencies: [.target(name: "WordPressSharedObjC")], resources: [.process("Resources")], swiftSettings: [.swiftLanguageMode(.v5)]),
+        .target(
+            name: "WordPressShared",
+            dependencies: [
+                .target(name: "SFHFKeychainUtils"),
+                .target(name: "WordPressSharedObjC"),
+            ],
+            resources: [.process("Resources")],
+            swiftSettings: [.swiftLanguageMode(.v5)]
+        ),
         .target(name: "WordPressTesting", resources: [.process("Resources")]),
         .target(
             name: "WordPressUI",

…red/Utility/FileManager+FolderSize.swift …FileManager/FileManager+FolderSize.swiftModules/Sources/WordPressShared/Utility/FileManager+FolderSize.swift renamed to Modules/Sources/WordPressShared/FileManager/FileManager+FolderSize.swift Modules/Sources/WordPressShared/Utility/FileManager+FolderSize.swift renamed to Modules/Sources/WordPressShared/FileManager/FileManager+FolderSize.swift

@@ -0,0 +1,16 @@
+import Foundation
+
+extension FileManager: LocalFileStore {
+    public func containerURL(forAppGroup appGroup: String) -> URL? {
+        return containerURL(forSecurityApplicationGroupIdentifier: appGroup)
+    }
+
+    public func fileExists(at url: URL) -> Bool {
+        return fileExists(atPath: url.path)
+    }
+
+    @discardableResult
+    public func save(contents: Data, at url: URL) -> Bool {
+        return createFile(atPath: url.path, contents: contents)
+    }
+}

Modules/Sources/WordPressShared/FileManager/FileManager+LocalFileStore.swift

@@ -0,0 +1,22 @@
+import Foundation
+
+public protocol LocalFileStore {
+    func data(from url: URL) throws -> Data
+
+    func fileExists(at url: URL) -> Bool
+
+    @discardableResult
+    func save(contents: Data, at url: URL) -> Bool
+
+    func containerURL(forAppGroup appGroup: String) -> URL?
+
+    func removeItem(at url: URL) throws
+
+    func copyItem(at srcURL: URL, to dstURL: URL) throws
+}
+
+public extension LocalFileStore {
+    func data(from url: URL) throws -> Data {
+        return try Data(contentsOf: url)
+    }
+}

Modules/Sources/WordPressShared/FileManager/LocalFileStore.swift

@@ -0,0 +1,4 @@
+public protocol KeychainAccessible {
+    func getPassword(for username: String, serviceName: String) throws -> String
+    func setPassword(for username: String, to newValue: String?, serviceName: String) throws
+}

Modules/Sources/WordPressShared/Keychain/KeychainAccessible.swift

@@ -1,11 +1,11 @@
 import SFHFKeychainUtils
 
 @objcMembers
-class KeychainUtils: NSObject {
+public class KeychainUtils: NSObject {
 
     private let keychainUtils: SFHFKeychainUtils.Type
 
-    init(keychainUtils: SFHFKeychainUtils.Type = SFHFKeychainUtils.self) {
+    public init(keychainUtils: SFHFKeychainUtils.Type = SFHFKeychainUtils.self) {
         self.keychainUtils = keychainUtils
     }
 
@@ -29,7 +29,8 @@ class KeychainUtils: NSObject {
         return try keychainUtils.getPasswordForUsername(username, andServiceName: serviceName, accessGroup: accessGroup)
     }
 
-    func store(username: String, password: String, serviceName: String, accessGroup: String? = nil, updateExisting: Bool) throws {
+    // FIXME: Might become internal once all consumers interface with this via `KeychainAccessible`
+    public func store(username: String, password: String, serviceName: String, accessGroup: String? = nil, updateExisting: Bool) throws {
         return try keychainUtils.storeUsername(username,
                                                andPassword: password,
                                                forServiceName: serviceName,
@@ -39,20 +40,15 @@ class KeychainUtils: NSObject {
 }
 
 extension KeychainUtils: KeychainAccessible {
-    func getPassword(for username: String, serviceName: String) throws -> String {
+    public func getPassword(for username: String, serviceName: String) throws -> String {
         try self.keychainUtils.getPasswordForUsername(username, andServiceName: serviceName)
     }
 
-    func setPassword(for username: String, to newValue: String?, serviceName: String) throws {
+    public func setPassword(for username: String, to newValue: String?, serviceName: String) throws {
         if let newValue {
             try keychainUtils.storeUsername(username, andPassword: newValue, forServiceName: serviceName, updateExisting: true)
         } else {
             try keychainUtils.deleteItem(forUsername: username, andServiceName: serviceName)
         }
     }
 }
-
-protocol KeychainAccessible {
-    func getPassword(for username: String, serviceName: String) throws -> String
-    func setPassword(for username: String, to newValue: String?, serviceName: String) throws
-}

…ress/Classes/Utility/KeychainUtils.swift …PressShared/Keychain/KeychainUtils.swiftWordPress/Classes/Utility/KeychainUtils.swift renamed to Modules/Sources/WordPressShared/Keychain/KeychainUtils.swift WordPress/Classes/Utility/KeychainUtils.swift renamed to Modules/Sources/WordPressShared/Keychain/KeychainUtils.swift

@@ -0,0 +1,5 @@
+import Foundation
+
+public typealias UserPersistentRepository = UserPersistentRepositoryReader & UserPersistentRepositoryWriter & UserPersistentRepositoryUtility
+
+extension UserDefaults: UserPersistentRepository {}

Modules/Sources/WordPressShared/UserPersistentRepository/UserPersistentRepository.swift

@@ -0,0 +1,11 @@
+public protocol UserPersistentRepositoryReader {
+    func string(forKey key: String) -> String?
+    func bool(forKey key: String) -> Bool
+    func integer(forKey key: String) -> Int
+    func float(forKey key: String) -> Float
+    func double(forKey key: String) -> Double
+    func array(forKey key: String) -> [Any]?
+    func dictionary(forKey key: String) -> [String: Any]?
+    func url(forKey key: String) -> URL?
+    func dictionaryRepresentation() -> [String: Any]
+}

Modules/Sources/WordPressShared/UserPersistentRepository/UserPersistentRepositoryReader.swift

@@ -0,0 +1,45 @@
+public protocol UserPersistentRepositoryUtility: AnyObject {
+    var onboardingNotificationsPromptDisplayed: Bool { get set }
+    var notificationPrimerAlertWasDisplayed: Bool { get set }
+}
+
+public enum UPRUConstants {
+    static let promptKey = "onboarding_notifications_prompt_displayed"
+    static let questionKey = "onboarding_question_selection"
+    static let notificationPrimerAlertWasDisplayed = "NotificationPrimerAlertWasDisplayed"
+    public static let notificationsTabAccessCount = "NotificationsTabAccessCount"
+    public static let notificationPrimerInlineWasAcknowledged = "notificationPrimerInlineWasAcknowledged"
+    public static let secondNotificationsAlertCount = "secondNotificationsAlertCount"
+    public static let hasShownCustomAppIconUpgradeAlert = "custom-app-icon-upgrade-alert-shown"
+    public static let savedPostsPromoWasDisplayed = "SavedPostsV1PromoWasDisplayed"
+    public static let currentAnnouncementsKey = "currentAnnouncements"
+    public static let currentAnnouncementsDateKey = "currentAnnouncementsDate"
+    public static let announcementsVersionDisplayedKey = "announcementsVersionDisplayed"
+    public static let isJPContentImportCompleteKey = "jetpackContentImportComplete"
+    public static let jetpackContentMigrationStateKey = "jetpackContentMigrationState"
+    public static let mediaAspectRatioModeEnabledKey = "mediaAspectRatioModeEnabled"
+    public static let readerSidebarSelectionKey = "readerSidebarSelectionKey"
+    public static let isReaderSelectedKey = "isReaderSelectedKey"
+    public static let readerSearchHistoryKey = "readerSearchHistoryKey"
+    public static let readerDidSelectInterestsKey = "readerDidSelectInterestsKey"
+}
+
+public extension UserPersistentRepositoryUtility {
+    var onboardingNotificationsPromptDisplayed: Bool {
+        get {
+            UserPersistentStoreFactory.instance().bool(forKey: UPRUConstants.promptKey)
+        }
+        set {
+            UserPersistentStoreFactory.instance().set(newValue, forKey: UPRUConstants.promptKey)
+        }
+    }
+
+    var notificationPrimerAlertWasDisplayed: Bool {
+        get {
+            UserPersistentStoreFactory.instance().bool(forKey: UPRUConstants.notificationPrimerAlertWasDisplayed)
+        }
+        set {
+            UserPersistentStoreFactory.instance().set(newValue, forKey: UPRUConstants.notificationPrimerAlertWasDisplayed)
+        }
+    }
+}

Modules/Sources/WordPressShared/UserPersistentRepository/UserPersistentRepositoryUtitility.swift

@@ -0,0 +1,9 @@
+public protocol UserPersistentRepositoryWriter: KeyValueDatabase {
+    func set(_ value: Any?, forKey key: String)
+    func set(_ value: Int, forKey key: String)
+    func set(_ value: Float, forKey key: String)
+    func set(_ value: Double, forKey key: String)
+    func set(_ value: Bool, forKey key: String)
+    func set(_ url: URL?, forKey key: String)
+    func removeObject(forKey key: String)
+}