Skip to content

Conversation

@kean
Copy link
Contributor

@kean kean commented Sep 11, 2025

Screenshot 2025-12-01 at 11 52 12 AM

@kean kean added this to the Someday milestone Sep 11, 2025
@kean kean added the Reader label Sep 11, 2025
@sonarqubecloud
Copy link

@kean kean marked this pull request as draft September 11, 2025 13:34
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 11, 2025

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number30224
VersionPR #24828
Bundle IDorg.wordpress.alpha
Commit9f7941a
Installation URL40jerdvtfmg68
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 11, 2025

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number30224
VersionPR #24828
Bundle IDcom.jetpack.alpha
Commit9f7941a
Installation URL1gsltds8pgn2g
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@kean kean force-pushed the task/freshly-pressed branch from b524533 to 96c802d Compare November 25, 2025 13:11
@kean kean changed the title Add Freshly Pressed Reader: Add Freshly Pressed Nov 25, 2025
@kean kean modified the milestones: Someday, 26.6 Nov 25, 2025
// A workaround for https://linear.app/a8c/issue/CMM-994/reader-invalid-featured-images-for-posts-in-freshly-pressed-feed
// The app does not support `mshots` images. We also never want to show
// screenshots of posts as featured images, so it's safe to skip these.
if ([imageURL containsString:@"wp.com/mshots/"]) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured we can opt-out of these on the app side as we never want mshots to be used from the app.

@kean kean requested a review from crazytonyli December 1, 2025 16:54
@kean kean marked this pull request as ready for review December 2, 2025 00:04
@kean kean requested a review from jkmassel December 3, 2025 19:40
let topic = context.insertNewObject(ofType: ReaderSiteTopic.self)
topic.feedURL = path
topic.path = path
try? context.save()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have many places in the app that save the main context. Maybe use performAndSave like the rest of the app?

@kean kean force-pushed the task/freshly-pressed branch from 505077c to d8791e5 Compare December 22, 2025 22:45
@kean kean enabled auto-merge December 22, 2025 22:45
@kean kean added this pull request to the merge queue Dec 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 22, 2025
@kean kean force-pushed the task/freshly-pressed branch from d8791e5 to 9f7941a Compare December 23, 2025 13:06
@kean kean enabled auto-merge December 23, 2025 13:06
@sonarqubecloud
Copy link

@kean kean added this pull request to the merge queue Dec 23, 2025
Merged via the queue into trunk with commit 87ec186 Dec 23, 2025
26 of 32 checks passed
@kean kean deleted the task/freshly-pressed branch December 23, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants