-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Rename External Links to Clicks #25090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b756239 to
c167548
Compare
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 30256 | |
| Version | PR #25090 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 93b9aed | |
| Installation URL | 1fclehqbeejn0 |
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 30256 | |
| Version | PR #25090 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 93b9aed | |
| Installation URL | 67ifg5gd508m0 |
| static let referrers = AppLocalizedString("jetpackStats.siteDataTypes.referrers", value: "Referrers", comment: "Referrers data type") | ||
| static let locations = AppLocalizedString("jetpackStats.siteDataTypes.locations", value: "Locations", comment: "Locations data type") | ||
| static let externalLinks = AppLocalizedString("jetpackStats.siteDataTypes.externalLinks", value: "External Links", comment: "External links data type") | ||
| static let externalLinks = AppLocalizedString("jetpackStats.siteDataTypes.clicks", value: "Clicks", comment: "Clicks data type (external links)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be trivial to rename the externalLinks symbol too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
c167548 to
93b9aed
Compare
|





Description
Fixes https://linear.app/a8c/issue/CMM-1089/jetpack-ios-clicks-section-missing-from-new-stats-experience.