Skip to content

Conversation

@kean
Copy link
Contributor

@kean kean commented Dec 22, 2025

@kean kean added this to the 26.6 milestone Dec 22, 2025
@kean kean requested a review from crazytonyli December 22, 2025 22:53
@kean kean added the Stats label Dec 22, 2025
@kean kean force-pushed the fix/rename-state-external-links branch from b756239 to c167548 Compare December 22, 2025 22:53
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 22, 2025

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number30256
VersionPR #25090
Bundle IDorg.wordpress.alpha
Commit93b9aed
Installation URL1fclehqbeejn0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 22, 2025

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number30256
VersionPR #25090
Bundle IDcom.jetpack.alpha
Commit93b9aed
Installation URL67ifg5gd508m0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

static let referrers = AppLocalizedString("jetpackStats.siteDataTypes.referrers", value: "Referrers", comment: "Referrers data type")
static let locations = AppLocalizedString("jetpackStats.siteDataTypes.locations", value: "Locations", comment: "Locations data type")
static let externalLinks = AppLocalizedString("jetpackStats.siteDataTypes.externalLinks", value: "External Links", comment: "External links data type")
static let externalLinks = AppLocalizedString("jetpackStats.siteDataTypes.clicks", value: "Clicks", comment: "Clicks data type (external links)")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be trivial to rename the externalLinks symbol too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@kean kean force-pushed the fix/rename-state-external-links branch from c167548 to 93b9aed Compare January 5, 2026 15:16
@kean kean enabled auto-merge January 5, 2026 15:16
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2026

@kean kean added this pull request to the merge queue Jan 5, 2026
Merged via the queue into trunk with commit 38e0e9c Jan 5, 2026
26 of 32 checks passed
@kean kean deleted the fix/rename-state-external-links branch January 5, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants