Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

Commit 5a7d637

Browse files
author
Paul Von Schrottky
committed
added missing files, fixed tests
1 parent a7ccb2e commit 5a7d637

File tree

3 files changed

+16
-4
lines changed

3 files changed

+16
-4
lines changed

Sources/WordPressKit/Services/StatsServiceRemoteV2.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,7 @@ public extension StatsServiceRemoteV2 {
324324
let pathComponent = StatsSubscribersSummaryData.pathComponent
325325
let path = self.path(forEndpoint: "sites/\(siteID)/\(pathComponent)/", withVersion: ._1_1)
326326
let properties = StatsSubscribersSummaryData.queryProperties(quantity: 30, unit: unit) as [String: AnyObject]
327-
327+
328328
wordPressComRESTAPI.get(path, parameters: properties, success: { [weak self] (response, _) in
329329
guard let self,
330330
let jsonResponse = response as? [String: AnyObject],

Tests/WordPressKitTests/Tests/Models/Stats/V2/StatsSubscribersSummaryDataTests.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ final class StatsSubscribersSummaryDataTests: XCTestCase {
88
let summary = StatsSubscribersSummaryData(jsonDictionary: json)
99
XCTAssertNotNil(summary, "StatsSubscribersSummaryData not decoded as expected")
1010
let history = summary!.history
11-
let firstDay = history[0]
11+
let mostRecentDay = history.last!
1212

13-
XCTAssertEqual(firstDay.date, ISO8601DateFormatter().date(from: "2024-04-22"))
14-
XCTAssertEqual(firstDay.count, 77)
13+
XCTAssertEqual(mostRecentDay.date, StatsSubscribersSummaryData.dateFormatter.date(from: "2024-04-22"))
14+
XCTAssertEqual(mostRecentDay.count, 77)
1515
}
1616
}
1717

WordPressKit.xcodeproj/project.pbxproj

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -573,6 +573,9 @@
573573
B04D8C0B2BB7895A002717A2 /* stats-insight.json in Resources */ = {isa = PBXBuildFile; fileRef = B04D8C002BB7895A002717A2 /* stats-insight.json */; };
574574
B04D8C0C2BB7895A002717A2 /* stats.json in Resources */ = {isa = PBXBuildFile; fileRef = B04D8C012BB7895A002717A2 /* stats.json */; };
575575
B04D8C0D2BB7895A002717A2 /* StatsInsightDecodingTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = B04D8C032BB7895A002717A2 /* StatsInsightDecodingTests.swift */; };
576+
B0E02FBA2BD899F600A0A561 /* StatsSubscribersSummaryDataTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = B0E02FB62BD8999B00A0A561 /* StatsSubscribersSummaryDataTests.swift */; };
577+
B0E02FBB2BD89A0400A0A561 /* stats-subscribers.json in Resources */ = {isa = PBXBuildFile; fileRef = B0E02FB82BD899C500A0A561 /* stats-subscribers.json */; };
578+
B0E02FBD2BD89AAB00A0A561 /* StatsSubscribersSummaryData.swift in Sources */ = {isa = PBXBuildFile; fileRef = B0E02FBC2BD89AAB00A0A561 /* StatsSubscribersSummaryData.swift */; };
576579
B5969E1C20A49AC4005E9DF1 /* NSString+MD5.h in Headers */ = {isa = PBXBuildFile; fileRef = B5969E1920A49AC4005E9DF1 /* NSString+MD5.h */; settings = {ATTRIBUTES = (Public, ); }; };
577580
B5969E1D20A49AC4005E9DF1 /* NSString+MD5.m in Sources */ = {isa = PBXBuildFile; fileRef = B5969E1A20A49AC4005E9DF1 /* NSString+MD5.m */; };
578581
B5A4822B20AC6C0B009D95F6 /* WPKitLogging.swift in Sources */ = {isa = PBXBuildFile; fileRef = B5A4822A20AC6C0B009D95F6 /* WPKitLogging.swift */; };
@@ -1329,6 +1332,9 @@
13291332
B04D8C002BB7895A002717A2 /* stats-insight.json */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.json; path = "stats-insight.json"; sourceTree = "<group>"; };
13301333
B04D8C012BB7895A002717A2 /* stats.json */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.json; path = stats.json; sourceTree = "<group>"; };
13311334
B04D8C032BB7895A002717A2 /* StatsInsightDecodingTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = StatsInsightDecodingTests.swift; sourceTree = "<group>"; };
1335+
B0E02FB62BD8999B00A0A561 /* StatsSubscribersSummaryDataTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = StatsSubscribersSummaryDataTests.swift; sourceTree = "<group>"; };
1336+
B0E02FB82BD899C500A0A561 /* stats-subscribers.json */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.json; path = "stats-subscribers.json"; sourceTree = "<group>"; };
1337+
B0E02FBC2BD89AAB00A0A561 /* StatsSubscribersSummaryData.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = StatsSubscribersSummaryData.swift; sourceTree = "<group>"; };
13321338
B5969E1920A49AC4005E9DF1 /* NSString+MD5.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "NSString+MD5.h"; sourceTree = "<group>"; };
13331339
B5969E1A20A49AC4005E9DF1 /* NSString+MD5.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "NSString+MD5.m"; sourceTree = "<group>"; };
13341340
B5A4822A20AC6C0B009D95F6 /* WPKitLogging.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = WPKitLogging.swift; sourceTree = "<group>"; };
@@ -1683,6 +1689,7 @@
16831689
3FE2E9362BB10EC7002CA2E1 /* Stats */ = {
16841690
isa = PBXGroup;
16851691
children = (
1692+
B0E02FBC2BD89AAB00A0A561 /* StatsSubscribersSummaryData.swift */,
16861693
019C5B8A2BD59CE000A69DB0 /* Emails */,
16871694
404057C3221B30140060250C /* Time Interval */,
16881695
40414061220F9F2800CF7C5B /* Insights */,
@@ -2267,6 +2274,7 @@
22672274
93BD27421EE73384002BB00B /* Mock Data */ = {
22682275
isa = PBXGroup;
22692276
children = (
2277+
B0E02FB82BD899C500A0A561 /* stats-subscribers.json */,
22702278
F4B0F4742ACB4176003ABC61 /* Domains */,
22712279
937250EB267A15060086075F /* stats-referrer-mark-as-spam.json */,
22722280
465F8892263B094900F4C950 /* BlockEditorSettings */,
@@ -2628,6 +2636,7 @@
26282636
F3FF8A1C279C86F600E5C90F /* V2 */ = {
26292637
isa = PBXGroup;
26302638
children = (
2639+
B0E02FB62BD8999B00A0A561 /* StatsSubscribersSummaryDataTests.swift */,
26312640
019C5B882BD59C7800A69DB0 /* Emails */,
26322641
01383F7D2BD5542300496B76 /* TimeInterval */,
26332642
F3FF8A1D279C86FE00E5C90F /* Insights */,
@@ -2866,6 +2875,7 @@
28662875
files = (
28672876
01438D392B6A361B0097D60A /* stats-summary.json in Resources */,
28682877
01438D362B6A31540097D60A /* stats-visits-month-unit-week.json in Resources */,
2878+
B0E02FBB2BD89A0400A0A561 /* stats-subscribers.json in Resources */,
28692879
32A29A1F236BE4CC009488C2 /* post-autosave-mapping-success.json in Resources */,
28702880
CEAD827B25E421DE00758DF2 /* reader-post-comments-subscribe-failure.json in Resources */,
28712881
7403A2FC1EF06FEB00DED7DC /* me-settings-change-lastname-success.json in Resources */,
@@ -3384,6 +3394,7 @@
33843394
404057DA221C9D560060250C /* StatsTopReferrersTimeIntervalData.swift in Sources */,
33853395
826016F11F9FA13A00533B6C /* ActivityServiceRemote.swift in Sources */,
33863396
74BA04FA1F06DC3900ED5CD8 /* RemoteComment.m in Sources */,
3397+
B0E02FBD2BD89AAB00A0A561 /* StatsSubscribersSummaryData.swift in Sources */,
33873398
40F98809221AC88700B7B369 /* StatsPostingStreakInsight.swift in Sources */,
33883399
465F889E263B0C5500F4C950 /* BlockEditorSettingsServiceRemote.swift in Sources */,
33893400
32FC1D29255C91ED00CD0A7B /* JetpackScanServiceRemote.swift in Sources */,
@@ -3538,6 +3549,7 @@
35383549
B04D8C0D2BB7895A002717A2 /* StatsInsightDecodingTests.swift in Sources */,
35393550
9F3E0BAE20873836009CB5BA /* ReaderTopicServiceRemoteTest+Subscriptions.swift in Sources */,
35403551
4A05E79E2B30F3C500C25E3B /* URLRequest+HTTPBodyText.swift in Sources */,
3552+
B0E02FBA2BD899F600A0A561 /* StatsSubscribersSummaryDataTests.swift in Sources */,
35413553
BA0637ED2492382200AF8419 /* PluginStateTests.swift in Sources */,
35423554
7328420621CD798A00126755 /* WordPressComServiceRemoteTests+SiteCreation.swift in Sources */,
35433555
FACBDD3825ECB4480026705B /* ReaderPostServiceRemote+RelatedPostsTests.swift in Sources */,

0 commit comments

Comments
 (0)