Extract DateFormatter RFC-3339 to file and rename to wordPressCom

Author: mokagio

WordPressKit.xcodeproj/project.pbxproj

@@ -73,6 +73,8 @@
 		3FB8642C2888089F003A86BE /* BuildkiteTestCollector in Frameworks */ = {isa = PBXBuildFile; productRef = 3FB8642B2888089F003A86BE /* BuildkiteTestCollector */; };
 		3FFCC0412BA995290051D229 /* NSDate+RFC3339Tests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3FFCC0402BA995290051D229 /* NSDate+RFC3339Tests.swift */; };
 		3FFCC0472BAA6EF40051D229 /* NSDate+RFC3339.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3FFCC0462BAA6EF40051D229 /* NSDate+RFC3339.swift */; };
+		3FFCC0492BAB98130051D229 /* DateFormatter+WordPressCom.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3FFCC0482BAB98130051D229 /* DateFormatter+WordPressCom.swift */; };
+		3FFCC04B2BABA5220051D229 /* DateFormatter+WordPressComTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3FFCC04A2BABA5220051D229 /* DateFormatter+WordPressComTests.swift */; };
 		40247DFA2120D8E100AE1C3C /* AutomatedTransferService.swift in Sources */ = {isa = PBXBuildFile; fileRef = 40247DF92120D8E100AE1C3C /* AutomatedTransferService.swift */; };
 		40247DFC2120E69600AE1C3C /* AutomatedTransferStatus.swift in Sources */ = {isa = PBXBuildFile; fileRef = 40247DFB2120E69600AE1C3C /* AutomatedTransferStatus.swift */; };
 		404057C5221B30400060250C /* StatsSearchTermTimeIntervalData.swift in Sources */ = {isa = PBXBuildFile; fileRef = 404057C4221B30400060250C /* StatsSearchTermTimeIntervalData.swift */; };
@@ -800,6 +802,8 @@
 		3FB8642D288813E9003A86BE /* UnitTests.xctestplan */ = {isa = PBXFileReference; lastKnownFileType = text; path = UnitTests.xctestplan; sourceTree = "<group>"; };
 		3FFCC0402BA995290051D229 /* NSDate+RFC3339Tests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "NSDate+RFC3339Tests.swift"; sourceTree = "<group>"; };
 		3FFCC0462BAA6EF40051D229 /* NSDate+RFC3339.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "NSDate+RFC3339.swift"; sourceTree = "<group>"; };
+		3FFCC0482BAB98130051D229 /* DateFormatter+WordPressCom.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "DateFormatter+WordPressCom.swift"; sourceTree = "<group>"; };
+		3FFCC04A2BABA5220051D229 /* DateFormatter+WordPressComTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "DateFormatter+WordPressComTests.swift"; sourceTree = "<group>"; };
 		40247DF92120D8E100AE1C3C /* AutomatedTransferService.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AutomatedTransferService.swift; sourceTree = "<group>"; };
 		40247DFB2120E69600AE1C3C /* AutomatedTransferStatus.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AutomatedTransferStatus.swift; sourceTree = "<group>"; };
 		404057C4221B30400060250C /* StatsSearchTermTimeIntervalData.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = StatsSearchTermTimeIntervalData.swift; sourceTree = "<group>"; };
@@ -1905,6 +1909,7 @@
 				74B335DB1F06F4180053A184 /* WordPressOrgXMLRPCApiTests.swift */,
 				740B23D51F17F7C100067A2A /* XMLRPCTestable.swift */,
 				3FFCC0402BA995290051D229 /* NSDate+RFC3339Tests.swift */,
+				3FFCC04A2BABA5220051D229 /* DateFormatter+WordPressComTests.swift */,
 			);
 			name = Tests;
 			sourceTree = "<group>";
@@ -2520,6 +2525,7 @@
 				4A05E7992B2FDC3200C25E3B /* WordPressOrgRestApi.swift */,
 				93BD27741EE73944002BB00B /* HTTPAuthenticationAlertController.swift */,
 				3FFCC0462BAA6EF40051D229 /* NSDate+RFC3339.swift */,
+				3FFCC0482BAB98130051D229 /* DateFormatter+WordPressCom.swift */,
 				93BD27771EE73944002BB00B /* WordPressComOAuthClient.swift */,
 				93BD27781EE73944002BB00B /* WordPressComRestApi.swift */,
 				93BD27791EE73944002BB00B /* WordPressOrgXMLRPCApi.swift */,
@@ -3516,6 +3522,7 @@
 				74C473AC1EF2F75E009918F2 /* SiteManagementServiceRemote.swift in Sources */,
 				74585B971F0D54B400E7E667 /* RemoteDomain.swift in Sources */,
 				0C1C08432B9CD8D200E52F8C /* PostServiceRemoteREST+Extended.swift in Sources */,
+				3FFCC0492BAB98130051D229 /* DateFormatter+WordPressCom.swift in Sources */,
 				74A44DD01F13C64B006CD8F4 /* RemoteNotification.swift in Sources */,
 				8B52B901257AC5A200221663 /* Date+endOfDay.swift in Sources */,
 				E1D6B558200E473A00325669 /* TimeZoneServiceRemote.swift in Sources */,
@@ -3643,6 +3650,7 @@
 				4A05E79C2B2FDC6100C25E3B /* WordPressOrgAPITests.swift in Sources */,
 				3297E1DE2564653A00287D21 /* JetpackScanServiceRemoteTests.swift in Sources */,
 				01438D352B6A2B2C0097D60A /* stats-visits-month-unit-week.json in Sources */,
+				3FFCC04B2BABA5220051D229 /* DateFormatter+WordPressComTests.swift in Sources */,
 				9F3E0BAC20873785009CB5BA /* ServiceRequestTest.swift in Sources */,
 				4624223E2548C26D002B8A12 /* SiteDesignServiceRemoteTests.swift in Sources */,
 				4A1DEF44293051BC00322608 /* LoggingTests.swift in Sources */,

WordPressKit/DateFormatter+WordPressCom.swift

@@ -0,0 +1,13 @@
+extension DateFormatter {
+
+    /// A `DateFormatter` configured to manage dates compatible with the WordPress.com API.
+    ///
+    /// - SeeAlso: [https://developer.wordpress.com/docs/api/](https://developer.wordpress.com/docs/api/)
+    static let wordPressCom: DateFormatter = {
+        let formatter = DateFormatter()
+        formatter.dateFormat = "yyyy'-'MM'-'dd'T'HH':'mm':'ssZ"
+        formatter.timeZone = NSTimeZone(forSecondsFromGMT: 0) as TimeZone
+        formatter.locale = NSLocale(localeIdentifier: "en_US_POSIX") as Locale
+        return formatter
+    }()
+}

WordPressKit/NSDate+RFC3339.swift

@@ -2,7 +2,7 @@ import Foundation
 
 extension NSDate {
 
-    static let rfc3339Formatter = DateFormatter.rfc3339Formatter
+    static let rfc3339Formatter = DateFormatter.wordPressCom
 
     /// Parses a date string
     ///
@@ -24,14 +24,3 @@ extension NSDate {
         NSDate.rfc3339Formatter.string(from: self as Date)
     }
 }
-
-extension DateFormatter {
-
-    static let rfc3339Formatter: DateFormatter = {
-        let formatter = DateFormatter()
-        formatter.dateFormat = "yyyy'-'MM'-'dd'T'HH':'mm':'ssZ"
-        formatter.timeZone = NSTimeZone(forSecondsFromGMT: 0) as TimeZone
-        formatter.locale = NSLocale(localeIdentifier: "en_US_POSIX") as Locale
-        return formatter
-    }()
-}

WordPressKitTests/DateFormatter+WordPressComTests.swift

@@ -0,0 +1,13 @@
+@testable import WordPressKit
+import XCTest
+
+class DateFormatterWordPressComTests: XCTestCase {
+
+    func testDateFormatterConfiguration() throws {
+        let rfc3339Formatter = try XCTUnwrap(DateFormatter.wordPressCom)
+
+        XCTAssertEqual(rfc3339Formatter.timeZone, TimeZone(secondsFromGMT: 0))
+        XCTAssertEqual(rfc3339Formatter.locale, Locale(identifier: "en_US_POSIX"))
+        XCTAssertEqual(rfc3339Formatter.dateFormat, "yyyy'-'MM'-'dd'T'HH':'mm':'ssZ")
+    }
+}

WordPressKitTests/NSDate+RFC3339Tests.swift

@@ -9,14 +9,6 @@ import XCTest
 // - https://datatracker.ietf.org/doc/html/rfc3339
 class NSDateRFC3339Tests: XCTestCase {
 
-    func testDateFormatterConfiguration() throws {
-        let rfc3339Formatter = try XCTUnwrap(NSDate.rfc3339Formatter)
-
-        XCTAssertEqual(rfc3339Formatter.timeZone, TimeZone(secondsFromGMT: 0))
-        XCTAssertEqual(rfc3339Formatter.locale, Locale(identifier: "en_US_POSIX"))
-        XCTAssertEqual(rfc3339Formatter.dateFormat, "yyyy'-'MM'-'dd'T'HH':'mm':'ssZ")
-    }
-
     func testValidRFC3339DateFromString() {
         XCTAssertEqual(
             NSDate.with(wordPressComJSONString: "2023-03-19T15:00:00Z"),