Skip to content

Commit 21d0336

Browse files
authored
Fix bug in configure_apply action (#612)
2 parents 8ed2bb1 + 21671e5 commit 21d0336

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

CHANGELOG.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ _None_
1414

1515
### Bug Fixes
1616

17-
_None_
17+
- Fix bug in `configure_apply` that could happen if run on a user machine that hasn't yet `git-pull` the latest commits from `~/.mobile-secrets` to a commit _after_ the new encryption key had been pushed. [#612]
1818

1919
### Internal Changes
2020

@@ -24,21 +24,21 @@ _None_
2424

2525
### Bug Fixes
2626

27-
- Fix issue with post-processing of PR urls in the body of GitHub releases created via `create_github_release` [#610]
27+
- Fix issue with post-processing of PR urls in the body of GitHub releases created via `create_github_release`. [#610]
2828

2929
## 12.3.0
3030

3131
### New Features
3232

33-
- `buildkite_pipeline_upload`: prepend `.buildkite/` to the `pipeline_file` parameter to enforce our conventions [#608]
33+
- `buildkite_pipeline_upload`: prepend `.buildkite/` to the `pipeline_file` parameter to enforce our conventions. [#608]
3434

3535
### Bug Fixes
3636

3737
- `create_release-backmerge_pull_request`: Fix the pre-check logic verifying if a PR is really needed or if there's nothing to backmerge. [#607]
3838

3939
### Internal Changes
4040

41-
- `buildkite_pipeline_upload`: makes sure all values passed in the environment parameter are strings [#608]
41+
- `buildkite_pipeline_upload`: makes sure all values passed in the environment parameter are strings. [#608]
4242

4343
## 12.2.1
4444

lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_apply_action.rb

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,10 @@ module Fastlane
1010
module Actions
1111
class ConfigureApplyAction < Action
1212
def self.run(params = {})
13-
# Preflight
14-
UI.user_error!('Decryption key could not be found') if Fastlane::Helper::ConfigureHelper.encryption_key.nil?
15-
1613
# Checkout the right commit hash etc. before applying the configuration
1714
prepare_repository do
15+
UI.user_error!('Decryption key could not be found') if Fastlane::Helper::ConfigureHelper.encryption_key.nil?
16+
1817
# Copy/decrypt the files
1918
files_to_copy.each do |file_reference|
2019
apply_file(file_reference, params[:force])

0 commit comments

Comments
 (0)