Fix RuboCop offenses after rebase; update rubocop_todo

Author: iangmaia

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2023-09-21 15:44:18 UTC using RuboCop version 1.56.3.
+# on 2023-11-08 13:49:19 UTC using RuboCop version 1.57.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -14,24 +14,16 @@ Gemspec/DevelopmentDependencies:
   Exclude:
     - 'fastlane-plugin-wpmreleasetoolkit.gemspec'
 
-# Offense count: 1
-# Configuration parameters: Severity, Include.
-# Include: **/*.gemspec
-Gemspec/RequiredRubyVersion:
-  Exclude:
-    - 'fastlane-plugin-wpmreleasetoolkit.gemspec'
-
 # Offense count: 3
 Lint/NonLocalExitFromIterator:
   Exclude:
     - 'lib/fastlane/plugin/wpmreleasetoolkit/actions/common/extract_release_notes_for_version_action.rb'
     - 'lib/fastlane/plugin/wpmreleasetoolkit/helper/android/android_localize_helper.rb'
 
-# Offense count: 7
+# Offense count: 4
 Naming/AccessorMethodName:
   Exclude:
     - 'lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_update_action.rb'
-    - 'lib/fastlane/plugin/wpmreleasetoolkit/helper/android/android_version_helper.rb'
     - 'lib/fastlane/plugin/wpmreleasetoolkit/helper/ios/ios_version_helper.rb'
 
 # Offense count: 2
@@ -42,7 +34,7 @@ Naming/MethodParameterName:
     - 'lib/fastlane/plugin/wpmreleasetoolkit/actions/android/an_update_metadata_source_action.rb'
     - 'lib/fastlane/plugin/wpmreleasetoolkit/actions/common/gp_update_metadata_source.rb'
 
-# Offense count: 108
+# Offense count: 109
 # Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
 # NamePrefix: is_, has_, have_
 # ForbiddenPrefixes: is_, has_, have_
@@ -68,7 +60,7 @@ RSpec/ContextWording:
     - 'spec/git_helper_spec.rb'
     - 'spec/ios_lint_localizations_spec.rb'
 
-# Offense count: 45
+# Offense count: 61
 # Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
 # Include: **/*_spec*rb*, **/spec/**/*
 RSpec/FilePath:
@@ -96,7 +88,7 @@ RSpec/NamedSubject:
     - 'spec/configuration_spec.rb'
     - 'spec/file_reference_spec.rb'
 
-# Offense count: 10
+# Offense count: 14
 RSpec/NestedGroups:
   Max: 5
 

Rakefile

@@ -56,7 +56,7 @@ task :new_release do
   Console.header 'Update `VERSION` constant in `version.rb`...'
   update_version_constant(VERSION_FILE, new_version)
   Console.header 'Updating CHANGELOG...'
-  parser.update_for_new_release(new_version:)
+  parser.update_for_new_release(new_version: new_version)
 
   # Commit and push
   Console.header 'Commit and push changes...'

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_betabuild_prechecks.rb

@@ -42,7 +42,7 @@ def self.run(params)
 
         # Check user overwrite
         unless params[:base_version].nil?
-          overwrite_version = get_user_build_version(version: params[:base_version], message:)
+          overwrite_version = get_user_build_version(version: params[:base_version], message: message)
           release_version = overwrite_version[0]
           alpha_release_version = overwrite_version[1]
         end

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_create_avd_action.rb

@@ -16,9 +16,9 @@ def self.run(params)
         helper.create_avd(
           api: api_level,
           device: device_model,
-          system_image:,
+          system_image: system_image,
           name: avd_name,
-          sdcard:
+          sdcard: sdcard
         )
       end
 

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_download_translations_action.rb

@@ -11,11 +11,11 @@ def self.run(params)
         res_dir = File.join(project_root_folder || '.', params[:res_dir])
 
         Fastlane::Helper::Android::LocalizeHelper.create_available_languages_file(
-          res_dir:,
+          res_dir: res_dir,
           locale_codes: [params[:source_locale]] + params[:locales].map { |h| h[:android] }
         )
         Fastlane::Helper::Android::LocalizeHelper.download_from_glotpress(
-          res_dir:,
+          res_dir: res_dir,
           glotpress_project_url: params[:glotpress_url],
           glotpress_filters: params[:status_filter].map { |s| { status: s } },
           locales_map: params[:locales]

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_firebase_test.rb

@@ -33,14 +33,14 @@ def self.run(params)
           project_id: params[:project_id],
           apk_path: params[:apk_path],
           test_apk_path: params[:test_apk_path],
-          device:,
+          device: device,
           test_targets: params[:test_targets],
           type: params[:type]
         )
 
         # Download all of the outputs from the job to the local machine
         FirebaseTestRunner.download_result_files(
-          result:,
+          result: result,
           destination: test_dir,
           project_id: params[:project_id],
           key_file_path: params[:key_file]

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_send_app_size_metrics.rb

@@ -42,18 +42,18 @@ def self.run(params)
           unless params[:aab_path].nil?
             generate_split_apks(aab_path: params[:aab_path]) do |apk|
               split_name = File.basename(apk, '.apk')
-              add_apk_size_metrics(helper: metrics_helper, apkanalyzer_bin:, apk:, split_name:)
+              add_apk_size_metrics(helper: metrics_helper, apkanalyzer_bin: apkanalyzer_bin, apk: apk, split_name: split_name)
             end
           end
           unless params[:universal_apk_path].nil?
-            add_apk_size_metrics(helper: metrics_helper, apkanalyzer_bin:, apk: params[:universal_apk_path], split_name: UNIVERSAL_APK_SPLIT_NAME)
+            add_apk_size_metrics(helper: metrics_helper, apkanalyzer_bin: apkanalyzer_bin, apk: params[:universal_apk_path], split_name: UNIVERSAL_APK_SPLIT_NAME)
           end
         end
 
         # Send the payload
         metrics_helper.send_metrics(
           to: api_url,
-          api_token:,
+          api_token: api_token,
           use_gzip: params[:use_gzip_content_encoding]
         )
       end

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_update_release_notes.rb

@@ -13,7 +13,7 @@ def self.run(params)
         path = params[:release_notes_file_path]
         next_version = Fastlane::Helper::Android::VersionHelper.calc_next_release_short_version(params[:new_version])
 
-        Fastlane::Helper::ReleaseNotesHelper.add_new_section(path:, section_title: next_version)
+        Fastlane::Helper::ReleaseNotesHelper.add_new_section(path: path, section_title: next_version)
         Fastlane::Helper::GitHelper.commit(message: "Release Notes: add new section for next version (#{next_version})", files: path)
 
         UI.message 'Done.'

lib/fastlane/plugin/wpmreleasetoolkit/actions/common/buildkite_annotate_action.rb

@@ -14,8 +14,8 @@ def self.run(params)
         else
           # Add new annotation using `buildkite-agent`
           extra_params = {
-            context:,
-            style:
+            context: context,
+            style: style
           }.compact.flat_map { |k, v| ["--#{k}", v] }
           sh('buildkite-agent', 'annotate', *extra_params, params[:message])
         end

lib/fastlane/plugin/wpmreleasetoolkit/actions/common/check_translation_progress.rb

@@ -15,7 +15,7 @@ def self.run(params)
 
         unless under_threshold_langs.empty?
           check_results(
-            under_threshold_langs:,
+            under_threshold_langs: under_threshold_langs,
             threshold: params[:min_acceptable_translation_percentage],
             skip_confirm: params[:skip_confirm]
           )
@@ -37,7 +37,7 @@ def self.check_translations(glotpress_url:, language_codes:, abort_on_violations
         under_threshold_langs = []
 
         data = begin
-          Fastlane::Helper::GlotPressHelper.get_translation_status_data(glotpress_url:)
+          Fastlane::Helper::GlotPressHelper.get_translation_status_data(glotpress_url: glotpress_url)
         rescue StandardError
           nil
         end
@@ -47,8 +47,8 @@ def self.check_translations(glotpress_url:, language_codes:, abort_on_violations
           UI.message("> Getting translation status for #{language_code}")
           progress = begin
             Fastlane::Helper::GlotPressHelper.get_translation_status(
-              data:,
-              language_code:
+              data: data,
+              language_code: language_code
             )
           rescue StandardError
             -1
@@ -60,7 +60,7 @@ def self.check_translations(glotpress_url:, language_codes:, abort_on_violations
           end
 
           UI.message("Language #{language_code} is #{progress}% translated.")
-          under_threshold_langs.push({ lang: language_code, progress: }) if progress < threshold
+          under_threshold_langs.push({ lang: language_code, progress: progress }) if progress < threshold
         end
 
         under_threshold_langs