Skip to content

Commit ae15983

Browse files
authored
Re-introduce prototype_build_details_comment refactoring for FAD (#639)
2 parents 71d53c6 + b1f7eb8 commit ae15983

File tree

4 files changed

+487
-566
lines changed

4 files changed

+487
-566
lines changed

CHANGELOG.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66

77
### Breaking Changes
88

9-
_None_
9+
- The `prototype_build_details_comment` action now relies on the `lane_context` of `firebase_app_distribution` instead of the one from `appcenter_upload` for the implicit metadata and download URL to use in the comment.
10+
This is in the context of us moving from App Center (which will be shut down in March 2025) to Firebase App Distribution as our primary mechanism to distribute prototype builds. [#630]
1011

1112
### New Features
1213

@@ -28,7 +29,7 @@ _None_
2829

2930
### Internal Changes
3031

31-
- The library now uses immutable literals, via `# frozen_strings_literal: true`. This may result in runtime issues that we will address ASAP once discovered [#626]
32+
- The library now uses immutable literals, via `# frozen_strings_literal: true`. This may result in runtime issues that we will address ASAP once discovered. [#626]
3233

3334
## 12.4.0
3435

@@ -39,7 +40,7 @@ _None_
3940

4041
### Bug Fixes
4142

42-
- Remove period from "Update draft release notes..." commit message [#622]
43+
- Remove period from "Update draft release notes..." commit message. [#622]
4344

4445
## 12.3.4
4546

MIGRATION.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Migration Instructions for Major Releases
22

3+
## From 12.x to 13.0.0
4+
5+
- The `prototype_build_details_comment` action have been updated to work with Firebase App Distribution instead of App Center [#630].
6+
- If you were using the `prototype_build_details_comment` action in concert with the `appcenter_upload` action, you'll need to migrate to use `firebase_app_distribution` action instead, then adjust the parameters for `prototype_build_details_comment` accordingly (mostly removing the `appcenter_upload`-related ones like `app_center_org_name`).
7+
- If you were using the `prototype_build_details_comment` action out of the context of App Center but with a `download_url` instead (e.g. Cloudfront URL), no update of the call site is needed.
8+
39
## From 11.x to 12.0.0
410

511
- `android_current_branch_is_hotfix` no longer supports the `build_gradle_path` parameter. Convert the project to define `versionName` and `versionCode` in `version.properties` and call `android_current_branch_is_hotfix` with `version_properties_path`.

0 commit comments

Comments
 (0)