Drop build.gradle support when version.properties can be used (#579)

Author: mokagio

CHANGELOG.md

@@ -6,7 +6,7 @@
 
 ### Breaking Changes
 
-_None_
+- Remove `build_gradle_path` parameter from `android_current_branch_is_hotfix` [#579]
 
 ### New Features
 
@@ -18,15 +18,26 @@ _None_
 
 ### Internal Changes
 
-- Deprecated the following actions: [#577]
+- Deprecated the following actions: [#577, #579]
     - `android_betabuild_prechecks`
     - `android_build_prechecks`
+    - `android_bump_version_beta`
+    - `android_bump_version_final_release`
+    - `android_bump_version_hotfix`
+    - `android_bump_version_release`
     - `android_codefreeze_prechecks`
     - `android_completecodefreeze_prechecks`
     - `android_finalize_prechecks`
+    - `android_get_alpha_version`
+    - `android_get_app_version`
+    - `android_get_release_version`
     - `android_hotfix_prechecks`
+    - `android_tag_build`
     - `ios_betabuild_prechecks`
     - `ios_build_prechecks`
+    - `ios_bump_version_beta`
+    - `ios_bump_version_hotfix`
+    - `ios_bump_version_release`
     - `ios_codefreeze_prechecks`
     - `ios_completecodefreeze_prechecks`
     - `ios_finalize_prechecks`

MIGRATION.md

@@ -1,5 +1,9 @@
 # Migration Instructions for Major Releases
 
+## From 11.x to 12.0.0
+
+- `android_current_branch_is_hotfix` no longer supports the `build_gradle_path` parameter. Convert the project to define `versionName` and `versionCode` in `version.properties` and call `android_current_branch_is_hotfix` with `version_properties_path`.
+
 ## From `10.0.0` to `11.0.0`
 
 - The `ios_check_beta_deps` now uses the `Podfile.lock` instead of `Podfile` for its detection. If you called this action with an explicit `podfile: …` argument, you'll have to update the call to use `lockfile:` instead—or remove that argument completely from your call and rely on its default value being `Podfile.lock`.

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_bump_version_beta.rb

@@ -78,6 +78,14 @@ def self.output
       def self.return_value
       end
 
+      def self.category
+        :deprecated
+      end
+
+      def self.deprecated_notes
+        'This action is deprecated and will be removed in the next major version update of the Release Toolkit. Please use the formatters and calculators in the Versioning module to automate version changes.'
+      end
+
       def self.authors
         ['Automattic']
       end

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_bump_version_final_release.rb

@@ -70,6 +70,14 @@ def self.available_options
         ]
       end
 
+      def self.category
+        :deprecated
+      end
+
+      def self.deprecated_notes
+        'This action is deprecated and will be removed in the next major version update of the Release Toolkit. Please use the formatters and calculators in the Versioning module to automate version changes.'
+      end
+
       def self.authors
         ['Automattic']
       end

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_bump_version_hotfix.rb

@@ -79,6 +79,14 @@ def self.available_options
         ]
       end
 
+      def self.category
+        :deprecated
+      end
+
+      def self.deprecated_notes
+        'This action is deprecated and will be removed in the next major version update of the Release Toolkit. Please use the formatters and calculators in the Versioning module to automate version changes.'
+      end
+
       def self.authors
         ['Automattic']
       end

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_bump_version_release.rb

@@ -97,6 +97,14 @@ def self.output
       def self.return_value
       end
 
+      def self.category
+        :deprecated
+      end
+
+      def self.deprecated_notes
+        'This action is deprecated and will be removed in the next major version update of the Release Toolkit. Please use the formatters and calculators in the Versioning module to automate version changes.'
+      end
+
       def self.authors
         ['Automattic']
       end

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_current_branch_is_hotfix.rb

@@ -8,11 +8,10 @@ class AndroidCurrentBranchIsHotfixAction < Action
       def self.run(params)
         require_relative '../../helper/android/android_version_helper'
 
-        build_gradle_path = params[:build_gradle_path]
         version_properties_path = params[:version_properties_path]
 
         version = Fastlane::Helper::Android::VersionHelper.get_release_version(
-          build_gradle_path: build_gradle_path,
+          build_gradle_path: nil,
           version_properties_path: version_properties_path
         )
         Fastlane::Helper::Android::VersionHelper.is_hotfix?(version)
@@ -32,16 +31,10 @@ def self.details
 
       def self.available_options
         [
-          FastlaneCore::ConfigItem.new(key: :build_gradle_path,
-                                       description: 'Path to the build.gradle file',
-                                       type: String,
-                                       optional: true,
-                                       conflicting_options: [:version_properties_path]),
           FastlaneCore::ConfigItem.new(key: :version_properties_path,
                                        description: 'Path to the version.properties file',
                                        type: String,
-                                       optional: true,
-                                       conflicting_options: [:build_gradle_path]),
+                                       optional: false),
         ]
       end
 

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_get_alpha_version.rb

@@ -49,6 +49,14 @@ def self.return_value
         'Return the alpha version of the app'
       end
 
+      def self.category
+        :deprecated
+      end
+
+      def self.deprecated_notes
+        'This action is deprecated and will be removed in the next major version update of the Release Toolkit. Please use the formatters and calculators in the Versioning module to automate version changes.'
+      end
+
       def self.authors
         # So no one will ever forget your contribution to fastlane :) You are awesome btw!
         ['Automattic']

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_get_app_version.rb

@@ -49,6 +49,14 @@ def self.return_value
         'Return the public version of the app'
       end
 
+      def self.category
+        :deprecated
+      end
+
+      def self.deprecated_notes
+        'This action is deprecated and will be removed in the next major version update of the Release Toolkit. Please use the formatters and calculators in the Versioning module to automate version changes.'
+      end
+
       def self.authors
         # So no one will ever forget your contribution to fastlane :) You are awesome btw!
         ['Automattic']

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_get_release_version.rb

@@ -49,6 +49,14 @@ def self.return_value
         'Return the public version of the app'
       end
 
+      def self.category
+        :deprecated
+      end
+
+      def self.deprecated_notes
+        'This action is deprecated and will be removed in the next major version update of the Release Toolkit. Please use the formatters and calculators in the Versioning module to automate version changes.'
+      end
+
       def self.authors
         # So no one will ever forget your contribution to fastlane :) You are awesome btw!
         ['Automattic']