Only trace authentication activity if the token is not cached (#177)

Co-authored-by: Carl Tremblay <carl.tremblay@workleap.com>

Author: Yalpe

src/Workleap.Extensions.Http.Authentication.ClientCredentialsGrant/ClientCredentialsTokenHttpMessageHandler.cs

@@ -40,7 +40,6 @@ public ClientCredentialsTokenHttpMessageHandler(IClientCredentialsTokenManagemen
     protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
     {
         this.EnsureRequestIsSentOverHttps(request);
-        using var activity = TracingHelper.StartAuthenticationActivity(this._options.ClientId);
         return await base.SendAsync(request, cancellationToken).ConfigureAwait(false);
     }
 

src/Workleap.Extensions.Http.Authentication.ClientCredentialsGrant/ClientCredentialsTokenManagementService.cs

@@ -1,4 +1,4 @@
-// This file is based on https://github.com/DuendeSoftware/Duende.AccessTokenManagement/blob/1.1.0/src/Duende.AccessTokenManagement/ClientCredentialsTokenManagementService.cs
+// This file is based on https://github.com/DuendeSoftware/Duende.AccessTokenManagement/blob/1.1.0/src/Duende.AccessTokenManagement/ClientCredentialsTokenManagementService.cs
 // Copyright (c) Brock Allen & Dominick Baier, licensed under the Apache License, Version 2.0. All rights reserved.
 //
 // The original file has been significantly modified, and these modifications are Copyright (c) Workleap, 2023.
@@ -81,6 +81,8 @@ private async Task<ClientCredentialsToken> SynchronizeAsync(string clientName, F
 
     private Func<Task<ClientCredentialsToken>> GetNewTokenTaskFactory(string clientName, CancellationToken cancellationToken) => async () =>
     {
+        using var activity = TracingHelper.StartAuthenticationActivity(this._optionsMonitor.Get(clientName).ClientId);
+
         var newToken = await this._tokenEndpointService.RequestTokenAsync(clientName, cancellationToken).ConfigureAwait(false);
 
         var cacheAbsoluteExpiration = await this._tokenCache.SetAsync(clientName, newToken, cancellationToken).ConfigureAwait(false);