fix: pass through non-json responses without modifying the body #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the issue where non-JSON responses were being modified by the loader wrapper. The changes introduce a new function to check for JSON responses and modify session handling to bypass these responses when they are not JSON.
- Added an isJsonResponse helper in utils.ts
- Updated the session handling in session.ts to return non-JSON responses unmodified
- Added test coverage in session.spec.ts for non-JSON responses
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/utils.ts | Added helper function isJsonResponse to detect JSON responses. |
| src/session.ts | Modified response handling to bypass non-JSON content. |
| src/session.spec.ts | Added tests to verify non-JSON responses are returned correctly. |
stacurry
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library is incorrectly expecting all responses passed through our loader wrapper to be returning JSON. This diff adds a check and passes through non-JSON responses without modifying the response body.