Skip to content

Commit 0f29f1e

Browse files
add roleSlug for createOrgMembership and fix updateOrgMemberhship (#278)
* add roleSlug param for createOrgMembership and fix updateOrgMemberhsip to allow for optional value for roleSlug * remove runtime type check and print statements
1 parent b47ee3c commit 0f29f1e

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

lib/UserManagement.php

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -218,18 +218,20 @@ public function deleteUser($userId)
218218
*
219219
* @param string $userId User ID
220220
* @param string $organizationId Organization ID
221+
* @param string|null $roleSlug Role Slug
221222
*
222223
* @throws Exception\WorkOSException
223224
*
224225
* @return Resource\OrganizationMembership
225226
*/
226-
public function createOrganizationMembership($userId, $organizationId)
227+
public function createOrganizationMembership($userId, $organizationId, $roleSlug = null)
227228
{
228229
$path = "user_management/organization_memberships";
229230

230231
$params = [
231232
"organization_id" => $organizationId,
232-
"user_id" => $userId
233+
"user_id" => $userId,
234+
"role_slug" => $roleSlug
233235
];
234236

235237
$response = Client::request(
@@ -295,18 +297,18 @@ public function deleteOrganizationMembership($organizationMembershipId)
295297
* Update a User organization membership.
296298
*
297299
* @param string $organizationMembershipId Organization Membership ID
298-
* @param string $role_slug The unique role identifier.
300+
* @param string|null $role_slug The unique role identifier.
299301
*
300302
* @throws Exception\WorkOSException
301303
*
302304
* @return Resource\OrganizationMembership
303305
*/
304-
public function updateOrganizationMembership($organizationMembershipId, $role_slug)
306+
public function updateOrganizationMembership($organizationMembershipId, $roleSlug = null)
305307
{
306308
$path = "user_management/organization_memberships/{$organizationMembershipId}";
307309

308310
$params = [
309-
"role_slug" => $role_slug
311+
"role_slug" => $roleSlug
310312
];
311313

312314
$response = Client::request(

tests/WorkOS/UserManagementTest.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -837,13 +837,15 @@ public function testCreateOrganizationMembership()
837837
{
838838
$userId = "user_01H7X1M4TZJN5N4HG4XXMA1234";
839839
$orgId = "org_01EHQMYV6MBK39QC5PZXHY59C3";
840+
$roleSlug = "admin";
840841
$path = "user_management/organization_memberships";
841842

842843
$result = $this->organizationMembershipResponseFixture();
843844

844845
$params = [
845846
"organization_id" => $orgId,
846-
"user_id" => $userId
847+
"user_id" => $userId,
848+
"role_slug" => $roleSlug
847849
];
848850

849851
$this->mockRequest(
@@ -857,7 +859,8 @@ public function testCreateOrganizationMembership()
857859

858860
$organizationMembership = $this->organizationMembershipFixture();
859861

860-
$response = $this->userManagement->createOrganizationMembership($userId, $orgId);
862+
$response = $this->userManagement->createOrganizationMembership($userId, $orgId, $roleSlug);
863+
861864
$this->assertSame($organizationMembership, $response->toArray());
862865
}
863866

0 commit comments

Comments
 (0)