Fix greptile-reported refresh bug and add test to prevent regressions

Author: birdcar

lib/CookieSession.php

@@ -84,7 +84,10 @@ public function refresh(array $options = [])
         // Use the refresh token to get new authentication tokens
         try {
             $refreshedAuth = $this->userManagement->authenticateWithRefreshToken(
+                WorkOS::getClientId(),
                 $authResult->refreshToken,
+                null,
+                null,
                 $organizationId
             );
 

tests/WorkOS/CookieSessionTest.php

@@ -94,4 +94,84 @@ public function testLoadSealedSessionReturnsValidCookieSession()
 
         $this->assertInstanceOf(CookieSession::class, $cookieSession);
     }
+
+    public function testRefreshPassesCorrectParametersToAuthenticateWithRefreshToken()
+    {
+        // REGRESSION TEST: Verify that CookieSession.refresh() passes all 5 parameters
+        // to authenticateWithRefreshToken(), not just 2. The clientId parameter must be
+        // included from WorkOS::getClientId() (see CookieSession.php:86-92)
+
+        $organizationId = "org_01H7X1M4TZJN5N4HG4XXMA1234";
+
+        // Create a mock UserManagement to verify method calls
+        $userManagementMock = $this->getMockBuilder(UserManagement::class)
+            ->onlyMethods(['authenticateWithSessionCookie', 'authenticateWithRefreshToken', 'sealSession'])
+            ->getMock();
+
+        // Mock authenticateWithSessionCookie to return a successful authentication
+        $authResponseData = [
+            'authenticated' => true,
+            'access_token' => 'test_access_token',
+            'refresh_token' => 'test_refresh_token',
+            'session_id' => 'session_123',
+            'user' => [
+                'object' => 'user',
+                'id' => 'user_123',
+                'email' => '[email protected]',
+                'first_name' => 'Test',
+                'last_name' => 'User',
+                'email_verified' => true,
+                'created_at' => '2021-01-01T00:00:00.000Z',
+                'updated_at' => '2021-01-01T00:00:00.000Z'
+            ]
+        ];
+        $authResponse = Resource\SessionAuthenticationSuccessResponse::constructFromResponse($authResponseData);
+        $userManagementMock->method('authenticateWithSessionCookie')
+            ->willReturn($authResponse);
+
+        // CRITICAL ASSERTION: Verify authenticateWithRefreshToken is called with exactly 5 parameters
+        $refreshResponseData = [
+            'access_token' => 'new_access_token',
+            'refresh_token' => 'new_refresh_token',
+            'user' => [
+                'object' => 'user',
+                'id' => 'user_123',
+                'email' => '[email protected]',
+                'first_name' => 'Test',
+                'last_name' => 'User',
+                'email_verified' => true,
+                'created_at' => '2021-01-01T00:00:00.000Z',
+                'updated_at' => '2021-01-01T00:00:00.000Z'
+            ]
+        ];
+        $refreshResponse = Resource\AuthenticationResponse::constructFromResponse($refreshResponseData);
+
+        $userManagementMock->expects($this->once())
+            ->method('authenticateWithRefreshToken')
+            ->with(
+                $this->identicalTo(WorkOS::getClientId()),  // clientId from config
+                $this->identicalTo('test_refresh_token'),    // refresh token
+                $this->identicalTo(null),                    // ipAddress
+                $this->identicalTo(null),                    // userAgent
+                $this->identicalTo($organizationId)          // organizationId
+            )
+            ->willReturn($refreshResponse);
+
+        $userManagementMock->method('sealSession')
+            ->willReturn('new_sealed_session');
+
+        // Execute refresh with the mocked UserManagement
+        $cookieSession = new CookieSession(
+            $userManagementMock,
+            $this->sealedSession,
+            $this->cookiePassword
+        );
+
+        [$response, $newSealedSession] = $cookieSession->refresh([
+            'organizationId' => $organizationId
+        ]);
+
+        // If we reach here without the mock throwing an exception, the test passes
+        $this->assertInstanceOf(Resource\SessionAuthenticationSuccessResponse::class, $response);
+    }
 }