Refactor mocking response

Author: Henry Chan

tests/conftest.py

@@ -1,7 +1,16 @@
 import pytest
+import requests
 
 import workos
 
+class MockResponse(object):
+    def __init__(self, response_dict, status_code):
+        self.response_dict = response_dict
+        self.status_code = status_code
+
+    def json(self):
+        return self.response_dict
+
 @pytest.fixture
 def set_api_key(monkeypatch):
     monkeypatch.setattr(workos, 'api_key', 'sk_abdsomecharactersm284')
@@ -12,4 +21,14 @@ def set_project_id(monkeypatch):
 
 @pytest.fixture
 def set_api_key_and_project_id(set_api_key, set_project_id):
-    pass
+    pass
+
+@pytest.fixture
+def mock_request_method(monkeypatch):
+    def _mock_request_method(method, response_dict, status_code):
+        def mock_response(*args, **kwargs):
+            return MockResponse(response_dict, status_code)
+
+        monkeypatch.setattr(requests, method, mock_response)
+
+    return _mock_request_method

tests/test_sso.py

@@ -2,20 +2,11 @@
 from urllib.parse import parse_qsl, urlparse
 
 import pytest
-import requests
 
 import workos
 from workos.sso import SSO
 from workos.utils.requests import RESPONSE_TYPE_CODE
 
-class MockResponse(object):
-    def __init__(self, response_dict, status_code):
-        self.response_dict = response_dict
-        self.status_code = status_code
-
-    def json(self):
-        return self.response_dict
-
 class TestSSO(object):
     @pytest.fixture(autouse=True)
     def setup(self, set_api_key_and_project_id):
@@ -36,24 +27,6 @@ def mock_profile(self):
             'idp_id': '00u1klkowm8EGah2H357'
         }
 
-    @pytest.fixture
-    def mock_request_post_profile(self, monkeypatch, mock_profile):
-        def mock_post(*args, **kwargs):
-            return MockResponse({
-                'profile': {
-                    'object': 'profile',
-                    'id': mock_profile['id'],
-                    'email': mock_profile['email'],
-                    'first_name': mock_profile['first_name'],
-                    'connection_type': mock_profile['connection_type'],
-                    'last_name': mock_profile['last_name'],
-                    'idp_id': mock_profile['idp_id'],
-                },
-                'access_token': '01DY34ACQTM3B1CSX1YSZ8Z00D',
-            }, 200)
-
-        monkeypatch.setattr(requests, 'post', mock_post)
-
     def test_authorization_url_has_expected_query_params(self):
         authorization_url = self.sso.get_authorization_url(
             self.customer_domain,
@@ -73,8 +46,23 @@ def test_authorization_url_has_expected_query_params(self):
 
 
     def test_get_profile_returns_expected_workosprofile_object(
-        self, mock_request_post_profile, mock_profile
+        self, mock_profile, mock_request_method
     ):
+        response_dict = {
+            'profile': {
+                'object': 'profile',
+                'id': mock_profile['id'],
+                'email': mock_profile['email'],
+                'first_name': mock_profile['first_name'],
+                'connection_type': mock_profile['connection_type'],
+                'last_name': mock_profile['last_name'],
+                'idp_id': mock_profile['idp_id'],
+            },
+            'access_token': '01DY34ACQTM3B1CSX1YSZ8Z00D',
+        }
+
+        mock_request_method('post', response_dict, 200)
+        
         profile = self.sso.get_profile(123)
 
         assert profile.to_dict() == mock_profile