Skip to content

Commit 5c5dfe1

Browse files
author
Rohan Jadvani
authored
Rename get_user endpoint and add get_user method (#24)
1 parent 2107ce5 commit 5c5dfe1

File tree

2 files changed

+33
-8
lines changed

2 files changed

+33
-8
lines changed

tests/test_directory_sync.py

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,10 @@ def mock_user(self):
8686
"id": "directory_usr_id",
8787
}
8888

89+
@pytest.fixture
90+
def mock_group(self):
91+
return {"name": "Developers", "id": "directory_grp_id"}
92+
8993
@pytest.fixture
9094
def mock_user_groups(self):
9195
return [{"name": "Developers", "id": "directory_grp_id"}]
@@ -149,12 +153,19 @@ def test_get_user(self, mock_user, mock_request_method):
149153
mock_response.status_code = 200
150154
mock_response.response_dict = mock_user
151155
mock_request_method("get", mock_response, 200)
152-
response = self.directory_sync.get_user(
153-
directory="directory_id", directory_user="directory_usr_id",
154-
)
156+
response = self.directory_sync.get_user(directory_user="directory_usr_id")
155157
assert response.status_code == 200
156158
assert response.response_dict == mock_user
157159

160+
def test_get_group(self, mock_group, mock_request_method):
161+
mock_response = Response()
162+
mock_response.status_code = 200
163+
mock_response.response_dict = mock_group
164+
mock_request_method("get", mock_response, 200)
165+
response = self.directory_sync.get_group(directory_group="directory_grp_id")
166+
assert response.status_code == 200
167+
assert response.response_dict == mock_group
168+
158169
def test_list_directories(self, mock_directories, mock_request_method):
159170
mock_response = Response()
160171
mock_response.status_code = 200

workos/directory_sync.py

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -76,19 +76,33 @@ def list_groups(
7676
token=workos.api_key,
7777
)
7878

79-
def get_user(self, directory, directory_user):
79+
def get_user(self, directory_user):
8080
"""Gets details for a single provisioned Directory User.
8181
8282
Args:
83-
directory (str): Directory unique identifier.
8483
directory_user (str): Directory User unique identifier.
8584
8685
Returns:
87-
dict: Directory user response from WorkOS.
86+
dict: Directory User response from WorkOS.
87+
"""
88+
return self.request_helper.request(
89+
"directory_users/{directory_user}".format(directory_user=directory_user),
90+
method=REQUEST_METHOD_GET,
91+
token=workos.api_key,
92+
)
93+
94+
def get_group(self, directory_group):
95+
"""Gets details for a single provisioned Directory Group.
96+
97+
Args:
98+
directory_group (str): Directory User unique identifier.
99+
100+
Returns:
101+
dict: Directory Group response from WorkOS.
88102
"""
89103
return self.request_helper.request(
90-
"directories/{directory}/users/{directory_user}".format(
91-
directory=directory, directory_user=directory_user,
104+
"directory_groups/{directory_group}".format(
105+
directory_group=directory_group
92106
),
93107
method=REQUEST_METHOD_GET,
94108
token=workos.api_key,

0 commit comments

Comments
 (0)