Skip to content

Commit 89ec35c

Browse files
authored
Merge pull request #7 from worksome/feature/otel-1.x
chore(deps): update to OpenTelemetry 1.x
2 parents cb3bd85 + db68b3d commit 89ec35c

File tree

4 files changed

+22
-20
lines changed

4 files changed

+22
-20
lines changed

README.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,24 +5,26 @@
55
[![GitHub Static Analysis Action Status](https://img.shields.io/github/actions/workflow/status/worksome/laravel-telemetry/static.yml?branch=main&style=flat-square&label=Static%20Analysis)](https://github.com/worksome/laravel-telemetry/actions?query=workflow%3A"Static%20Analysis"+branch%3Amain)
66
[![Total Downloads](https://img.shields.io/packagist/dt/worksome/laravel-telemetry.svg?style=flat-square)](https://packagist.org/packages/worksome/laravel-telemetry)
77

8-
This is where your description should go. Limit it to a paragraph or two. Consider adding a small example.
8+
Add [Open Telemetry](https://opentelemetry.io) support to Laravel.
99

10-
## Installation
10+
## Install
1111

1212
You can install the package via composer:
1313

14-
```bash
14+
```shell
1515
composer require worksome/laravel-telemetry
1616
```
1717

1818
You can publish the config file with:
1919

20-
```bash
20+
```shell
2121
php artisan vendor:publish --tag="laravel-telemetry-config"
2222
```
2323
## Usage
2424

25-
TODO
25+
This package will work out of the box with a default OTLP exporter configuration.
26+
27+
The default port is `4318`, and requests will be sent to `http://localhost:4318`.
2628

2729
## Testing
2830

composer.json

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,18 +18,18 @@
1818
"require": {
1919
"php": "^8.2",
2020
"illuminate/contracts": "^10.0",
21-
"open-telemetry/api": "^0.0.17",
22-
"open-telemetry/sdk": "^0.0.17",
23-
"open-telemetry/exporter-otlp": "^0.0.17",
21+
"open-telemetry/api": "^1.0",
22+
"open-telemetry/sdk": "^1.0",
23+
"open-telemetry/exporter-otlp": "^1.0",
2424
"php-http/guzzle7-adapter": "^1.0"
2525
},
2626
"require-dev": {
27-
"nunomaduro/collision": "^7.0",
28-
"nunomaduro/larastan": "^2.3.4",
29-
"orchestra/testbench": "^8.0",
30-
"pestphp/pest": "^2.0",
31-
"pestphp/pest-plugin-laravel": "^2.0",
32-
"worksome/coding-style": "^2.5"
27+
"nunomaduro/collision": "^7.10",
28+
"nunomaduro/larastan": "^2.6.4",
29+
"orchestra/testbench": "^8.15",
30+
"pestphp/pest": "^2.24.3",
31+
"pestphp/pest-plugin-laravel": "^2.2",
32+
"worksome/coding-style": "^2.6.1"
3333
},
3434
"autoload": {
3535
"psr-4": {

config/telemetry.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,5 @@
1818
],
1919
],
2020
],
21+
2122
];

src/LaravelTelemetryServiceProvider.php

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,20 @@
88
use Illuminate\Contracts\Events\Dispatcher;
99
use Illuminate\Queue\Events\WorkerStopping;
1010
use Illuminate\Support\ServiceProvider;
11+
use OpenTelemetry\API\LoggerHolder;
1112
use OpenTelemetry\API\Metrics\MeterProviderInterface;
1213
use OpenTelemetry\API\Trace\TracerProviderInterface;
1314
use OpenTelemetry\SDK\Common\Attribute\Attributes;
1415
use OpenTelemetry\SDK\Common\Configuration\Resolver\CompositeResolver;
1516
use OpenTelemetry\SDK\Common\Instrumentation\InstrumentationScopeFactory;
16-
use OpenTelemetry\SDK\Common\Log\LoggerHolder;
1717
use OpenTelemetry\SDK\Common\Time\ClockFactory;
18-
use OpenTelemetry\SDK\FactoryRegistry;
1918
use OpenTelemetry\SDK\Metrics\Exemplar\ExemplarFilter\WithSampledTraceExemplarFilter;
2019
use OpenTelemetry\SDK\Metrics\MeterProvider;
2120
use OpenTelemetry\SDK\Metrics\MeterProviderInterface as MeterProviderSdkInterface;
2221
use OpenTelemetry\SDK\Metrics\MetricReader\ExportingReader;
2322
use OpenTelemetry\SDK\Metrics\StalenessHandler\NoopStalenessHandlerFactory;
2423
use OpenTelemetry\SDK\Metrics\View\CriteriaViewRegistry;
24+
use OpenTelemetry\SDK\Registry;
2525
use OpenTelemetry\SDK\Resource\ResourceInfoFactory;
2626
use OpenTelemetry\SDK\Trace\TracerProviderFactory;
2727
use OpenTelemetry\SDK\Trace\TracerProviderInterface as TracerProviderSdkInterface;
@@ -44,8 +44,7 @@ public function register(): void
4444
new InstrumentationScopeFactory(Attributes::factory()),
4545
[
4646
new ExportingReader(
47-
FactoryRegistry::metricExporterFactory('otlp')->create(),
48-
ClockFactory::getDefault()
47+
Registry::metricExporterFactory('otlp')->create(),
4948
),
5049
],
5150
new CriteriaViewRegistry(),
@@ -70,11 +69,11 @@ public function register(): void
7069
public function boot(): void
7170
{
7271
$this->publishes([
73-
__DIR__.'/../config/telemetry.php' => $this->app->configPath('telemetry.php'),
72+
__DIR__ . '/../config/telemetry.php' => $this->app->configPath('telemetry.php'),
7473
], 'laravel-telemetry-config');
7574

7675
$this->mergeConfigFrom(
77-
__DIR__.'/../config/telemetry.php',
76+
__DIR__ . '/../config/telemetry.php',
7877
'telemetry',
7978
);
8079

0 commit comments

Comments
 (0)