Skip to content

Commit 34d1a0f

Browse files
authored
Merge pull request #31 from holixfactory/compose-1.5
Use compose-1.5 as main branch
2 parents 5fdb60b + 57d9bde commit 34d1a0f

File tree

6 files changed

+27
-25
lines changed

6 files changed

+27
-25
lines changed

app/build.gradle

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,11 @@ android {
2828
}
2929
}
3030
compileOptions {
31-
sourceCompatibility JavaVersion.VERSION_1_8
32-
targetCompatibility JavaVersion.VERSION_1_8
31+
sourceCompatibility JavaVersion.VERSION_17
32+
targetCompatibility JavaVersion.VERSION_17
3333
}
3434
kotlinOptions {
35-
jvmTarget = '1.8'
35+
jvmTarget = '17'
3636
}
3737
buildFeatures {
3838
compose = true
@@ -45,6 +45,7 @@ android {
4545

4646
dependencies {
4747
implementation project(":bottomsheetdialog-compose")
48+
implementation platform(Dependencies.composeBom)
4849
implementation Dependencies.composeUI
4950
implementation Dependencies.composeFoundation
5051
implementation Dependencies.composeMaterial

bottomsheetdialog-compose/build.gradle

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@ android {
3434
}
3535
}
3636
compileOptions {
37-
sourceCompatibility JavaVersion.VERSION_1_8
38-
targetCompatibility JavaVersion.VERSION_1_8
37+
sourceCompatibility JavaVersion.VERSION_17
38+
targetCompatibility JavaVersion.VERSION_17
3939
}
4040
kotlinOptions {
41-
jvmTarget = '1.8'
41+
jvmTarget = '17'
4242
}
4343
buildFeatures {
4444
buildConfig = false
@@ -50,6 +50,7 @@ android {
5050
}
5151

5252
dependencies {
53+
implementation platform(Dependencies.composeBom)
5354
implementation Dependencies.composeUI
5455
implementation Dependencies.composeFoundation
5556
implementation Dependencies.androidxActivityKtx

bottomsheetdialog-compose/src/main/kotlin/com/holix/android/bottomsheetdialog/compose/BottomSheetDialog.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,6 @@ private class BottomSheetDialogWrapper(
387387

388388
init {
389389
val window = window ?: error("Dialog has no window")
390-
window.requestFeature(Window.FEATURE_NO_TITLE)
391390
window.setBackgroundDrawableResource(android.R.color.transparent)
392391
bottomSheetDialogLayout = BottomSheetDialogLayout(context, window).apply {
393392
// Set unique id for AbstractComposeView. This allows state restoration for the state
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
package com.holix.android.bottomsheetdialog.compose
22

33
object Configuration {
4-
const val compileSdk = 33
4+
const val compileSdk = 34
55
const val targetSdk = 33
66
const val minSdk = 21
77
const val majorVersion = 1
8-
const val minorVersion = 2
8+
const val minorVersion = 3
99
const val patchVersion = 1
1010
const val versionName = "$majorVersion.$minorVersion.$patchVersion"
11-
const val versionCode = 121
11+
const val versionCode = 131
1212
const val snapshotVersionName = "$majorVersion.$minorVersion.${patchVersion + 1}-SNAPSHOT"
1313
const val artifactGroup = "com.holix.android"
1414
}

buildSrc/src/main/kotlin/com/holix/android/bottomsheetdialog/compose/Versions.kt

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
package com.holix.android.bottomsheetdialog.compose
22

33
object Versions {
4-
internal const val ANDROID_GRADLE_PLUGIN = "7.3.1"
4+
internal const val ANDROID_GRADLE_PLUGIN = "8.1.0"
55
internal const val GRADLE_NEXUS_PUBLISH_PLUGIN = "1.1.0"
6-
internal const val KOTLIN = "1.8.10"
6+
internal const val KOTLIN = "1.9.0"
77

8-
internal const val MATERIAL = "1.8.0"
9-
internal const val ANDROIDX_CORE_KTX = "1.10.0"
8+
internal const val MATERIAL = "1.9.0"
9+
internal const val ANDROIDX_CORE_KTX = "1.10.1"
1010

11-
internal const val COMPOSE = "1.4.1"
12-
const val COMPOSE_COMPILER = "1.4.3"
13-
internal const val ANDROIDX_ACTIVITY = "1.7.0"
11+
internal const val COMPOSE_BOM = "2023.08.00"
12+
const val COMPOSE_COMPILER = "1.5.1"
13+
internal const val ANDROIDX_ACTIVITY = "1.7.2"
1414

1515
internal const val COLOR_PICKER = "1.0.0"
1616
}
@@ -26,11 +26,12 @@ object Dependencies {
2626
const val androidxActivityKtx = "androidx.activity:activity-ktx:${Versions.ANDROIDX_ACTIVITY}"
2727
const val androidxCoreKtx = "androidx.core:core-ktx:${Versions.ANDROIDX_CORE_KTX}"
2828

29-
const val composeUI = "androidx.compose.ui:ui:${Versions.COMPOSE}"
30-
const val composeRuntime = "androidx.compose.runtime:runtime:${Versions.COMPOSE}"
31-
const val composeMaterial = "androidx.compose.material:material:${Versions.COMPOSE}"
32-
const val composeFoundation = "androidx.compose.foundation:foundation:${Versions.COMPOSE}"
33-
const val composeTooling = "androidx.compose.ui:ui-tooling:${Versions.COMPOSE}"
29+
const val composeBom = "androidx.compose:compose-bom:${Versions.COMPOSE_BOM}"
30+
const val composeUI = "androidx.compose.ui:ui"
31+
const val composeRuntime = "androidx.compose.runtime:runtime"
32+
const val composeMaterial = "androidx.compose.material:material"
33+
const val composeFoundation = "androidx.compose.foundation:foundation"
34+
const val composeTooling = "androidx.compose.ui:ui-tooling"
3435
const val composeActivity = "androidx.activity:activity-compose:${Versions.ANDROIDX_ACTIVITY}"
3536

3637
const val colorPicker = "com.github.skydoves:colorpicker-compose:${Versions.COLOR_PICKER}"
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
#Thu Jun 30 03:04:54 KST 2022
1+
#Fri Aug 11 17:13:17 KST 2023
22
distributionBase=GRADLE_USER_HOME
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-bin.zip
43
distributionPath=wrapper/dists
5-
zipStorePath=wrapper/dists
4+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.0-bin.zip
65
zipStoreBase=GRADLE_USER_HOME
6+
zipStorePath=wrapper/dists

0 commit comments

Comments
 (0)