Left one comment that I'd like to see a response to. Otherwise looks good w.r.t. Token Router market orders and Matching Engine's execute order.

@fergarrui it would be nice to have the same sort of forge test(s) that demonstrate that 2x message fee would be required for the fast market order (since there are two Wormhole messages required to execute).

As far as the Token Router market order, I feel like this should be a forge test instead of in the typescript test just to be consistent with the other tests. I don't have a strong opinion here.

cc: @gator-boi in case you had any thoughts.

@a5-pickle

Are there existing tests already for that flow where 2 messages are sent?
I did set messageFee to > 0 in unit tests but all of them are passing using msg.value == messageFee().
There is an existing fast market order test which seems to send just 1 message. Is this the flow that sends 2 messages?

Thanks!

Left one comment that I'd like to see a response to. Otherwise looks good w.r.t. Token Router market orders and Matching Engine's execute order.
@fergarrui it would be nice to have the same sort of forge test(s) that demonstrate that 2x message fee would be required for the fast market order (since there are two Wormhole messages required to execute).
As far as the Token Router market order, I feel like this should be a forge test instead of in the typescript test just to be consistent with the other tests. I don't have a strong opinion here.
cc: @gator-boi in case you had any thoughts.

@a5-pickle

Are there existing tests already for that flow where 2 messages are sent? I did set messageFee to > 0 in unit tests but all of them are passing using msg.value == messageFee(). There is an existing fast market order test which seems to send just 1 message. Is this the flow that sends 2 messages?

Thanks!

I actually meant this workflow in the Token Router: https://github.com/wormhole-foundation/example-liquidity-layer/blob/main/evm/src/TokenRouter/assets/PlaceMarketOrder.sol#L144-L221.

Check out the TokenRouter.t.sol file for calls to placeFastMarketOrder. Let me know if you have any issues.

Left one comment that I'd like to see a response to. Otherwise looks good w.r.t. Token Router market orders and Matching Engine's execute order.
@fergarrui it would be nice to have the same sort of forge test(s) that demonstrate that 2x message fee would be required for the fast market order (since there are two Wormhole messages required to execute).
As far as the Token Router market order, I feel like this should be a forge test instead of in the typescript test just to be consistent with the other tests. I don't have a strong opinion here.
cc: @gator-boi in case you had any thoughts.

@a5-pickle
Are there existing tests already for that flow where 2 messages are sent? I did set messageFee to > 0 in unit tests but all of them are passing using msg.value == messageFee(). There is an existing fast market order test which seems to send just 1 message. Is this the flow that sends 2 messages?
Thanks!

I actually meant this workflow in the Token Router: https://github.com/wormhole-foundation/example-liquidity-layer/blob/main/evm/src/TokenRouter/assets/PlaceMarketOrder.sol#L144-L221.

Check out the TokenRouter.t.sol file for calls to placeFastMarketOrder. Let me know if you have any issues.

I see what you mean, true, I added the same test for TokenRouter.