sdk: pr review cleanup

Author: kev1n-peters

evm/ts/src/axelar.ts

@@ -153,13 +153,20 @@ export async function getAxelarTransactionStatus(
 export function parseGMPStatus(response: any): GMPStatus | string {
   const { error, status } = response;
 
-  if (status === "error" && error) return GMPStatus.DEST_EXECUTE_ERROR;
-  else if (status === "executed") return GMPStatus.DEST_EXECUTED;
-  else if (status === "approved") return GMPStatus.DEST_GATEWAY_APPROVED;
-  else if (status === "called") return GMPStatus.SRC_GATEWAY_CALLED;
-  else if (status === "executing") return GMPStatus.DEST_EXECUTING;
-  else {
-    return status;
+  switch (status) {
+    case "error":
+      if (error) return GMPStatus.DEST_EXECUTE_ERROR;
+      return status;
+    case "executed":
+      return GMPStatus.DEST_EXECUTED;
+    case "approved":
+      return GMPStatus.DEST_GATEWAY_APPROVED;
+    case "called":
+      return GMPStatus.SRC_GATEWAY_CALLED;
+    case "executing":
+      return GMPStatus.DEST_EXECUTING;
+    default:
+      return status;
   }
 }
 

evm/ts/src/multiTokenNtt.ts

@@ -98,11 +98,8 @@ export class EvmMultiTokenNtt<N extends Network, C extends EvmChains>
         attestation.payload.nttManagerPayload
       )
     );
-    if (!isExecuted) return false;
 
-    // Also check that the transfer is not queued for it to be considered complete
-    const isInboundQueued = await this.getIsTransferInboundQueued(attestation);
-    return !isInboundQueued;
+    return isExecuted && !(await this.getIsTransferInboundQueued(attestation));
   }
 
   async getIsTransferInboundQueued(
@@ -681,6 +678,9 @@ export class EvmMultiTokenNtt<N extends Network, C extends EvmChains>
       return 1_000_000n;
     }
 
+    // Upper estimate for redeeming an existing token. Based on observed gas usage
+    // (~178k gas: https://sepolia.etherscan.io/tx/0xd008af053861cdfea0b6c1f4d973ee59f0c4fcc2e2de57b9945a193cb185bb29)
+    // but padded to be well above the limit.
     return 300_000n;
   }
 }

sdk/route/src/tracking.ts

@@ -20,6 +20,9 @@ export async function trackExecutor<
   }
 
   // Check if the relay was successful or failed
+  if (receipt.originTxs.length === 0) {
+    throw new Error("No origin transactions found in receipt");
+  }
   const txid = receipt.originTxs.at(-1)!.txid;
   const [txStatus] = await fetchStatus(network, txid, receipt.from);
   if (!txStatus) throw new Error("No transaction status found");
@@ -57,6 +60,9 @@ export async function trackAxelar<R extends MultiTokenNttRoute.TransferReceipt>(
   }
 
   // Check relayer status
+  if (receipt.originTxs.length === 0) {
+    throw new Error("No origin transactions found in receipt");
+  }
   const txid = receipt.originTxs.at(-1)!.txid;
   const axelarStatus = await getAxelarTransactionStatus(
     network,