evm: fix test_transceiverIncompatibleNttManager #672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test started failing as of forge v1.3.1, specifically due to this PR foundry-rs/foundry#10446. The PR implements better error reporting *when the tests run in verbose mode*, so the test that previously expected an empty revert string now fails in verbose mode, because forge now returns an error about calling a contract with no bytecode. Actually this test was supposed to test (according to the comment) that the transceiver constructor revert if the manager doesn't have the token method, but that's not what it was testing. So we change the test to actually use a dummy contract that has no token method. This returns an empty revert string, so everything is good. Until forge includes an override for that too at least
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the test_transceiverIncompatibleNttManager test that started failing after Forge v1.3.1 due to improved error reporting in verbose mode. The fix ensures the test properly validates that a transceiver constructor reverts when the manager doesn't have the required token method.
- Replace hardcoded address
0xBEEFwith a proper dummy contract that lacks thetokenmethod - Remove duplicate test from
NttManagerNoRateLimiting.t.solto eliminate redundancy - Maintain expected empty revert string behavior for better test reliability
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| evm/test/NttManager.t.sol | Adds DummyManager contract and updates test to use it instead of hardcoded address |
| evm/test/NttManagerNoRateLimiting.t.sol | Removes duplicate test_transceiverIncompatibleNttManagerNoRateLimiting function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
evan-gray
approved these changes
Aug 20, 2025
connorstake
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test started failing as of forge v1.3.1, specifically due to this PR foundry-rs/foundry#10446.
The PR implements better error reporting when the tests run in verbose mode, so the test that previously expected an empty revert string now fails in verbose mode, because forge now returns an error about calling a contract with no bytecode.
Actually this test was supposed to test (according to the comment) that the transceiver constructor revert if the manager doesn't have the token method, but that's not what it was testing. So we change the test to actually use a dummy contract that has no token method. This returns an empty revert string, so everything is good. Until forge includes an override for that too at least