Skip to content

task: Rename gossip messages to be tx_id instead of tx_hash  #4681

@johnsaigle

Description

@johnsaigle

We realized while reviewing another PR that the gossip messages should probably be updated to use TxID instead of TxHash.

Background for the original refactor: #4219


Yeah, I think all gossip messages (ObservationRequest, ChainGovernorStatus, and Observation) all use the outdated tx_hash as the name. I think it would be better to just rename all of those in a separate PR as I wouldn't want to touch the other message types.

Originally posted by @nvsriram in #4628 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions