make lint

Author: Bengt Lofgren

solana/programs/matching-engine/src/fallback/processor/execute_order.rs

@@ -442,7 +442,7 @@ pub fn handle_execute_order_shim(accounts: &[AccountInfo]) -> Result<()> {
     let fast_market_order_data = &fast_market_order_account.data.borrow()[8..];
     // Deserialise fast market order. Unwrap is safe because the account is owned by the matching engine program.
     let fast_market_order =
-        bytemuck::try_from_bytes::<FastMarketOrderState>(&fast_market_order_data[..]).unwrap();
+        bytemuck::try_from_bytes::<FastMarketOrderState>(fast_market_order_data).unwrap();
 
     // Prepare the execute order (get the user amount, fill, and order executed event)
     let active_auction_info = active_auction.info.as_ref().unwrap();
@@ -639,7 +639,7 @@ pub fn handle_execute_order_shim(accounts: &[AccountInfo]) -> Result<()> {
         order_sender: fast_market_order.sender,
         redeemer: fast_market_order.redeemer,
         redeemer_message: fast_market_order.redeemer_message
-            [..fast_market_order.redeemer_message_length as usize]
+            [..usize::from(fast_market_order.redeemer_message_length)]
             .to_vec()
             .try_into()
             .unwrap(),
@@ -690,7 +690,7 @@ pub fn handle_execute_order_shim(accounts: &[AccountInfo]) -> Result<()> {
         common::wormhole_cctp_solana::cpi::BurnAndPublishArgs {
             burn_source: None,
             destination_caller: to_router_endpoint.address,
-            destination_cctp_domain: destination_cctp_domain,
+            destination_cctp_domain,
             amount: user_amount,
             mint_recipient: to_router_endpoint.mint_recipient,
             wormhole_message_nonce: common::WORMHOLE_MESSAGE_NONCE,

solana/programs/matching-engine/tests/shimful/shims_execute_order.rs

@@ -58,15 +58,15 @@ impl ExecuteOrderFallbackAccounts {
         };
 
         Self {
-            signer: signer.clone(),
+            signer: *signer,
             custodian: auction_accounts.custodian,
-            fast_market_order_address: fast_market_order_address.clone(),
+            fast_market_order_address: *fast_market_order_address,
             active_auction: active_auction_state.auction_address,
             active_auction_custody_token: active_auction_state.auction_custody_token_address,
             active_auction_config: auction_accounts.auction_config,
             active_auction_best_offer_token: auction_accounts.offer_token,
             initial_offer_token: auction_accounts.offer_token,
-            initial_participant: signer.clone(),
+            initial_participant: *signer,
             to_router_endpoint: auction_accounts.to_router_endpoint,
             remote_token_messenger,
             token_messenger: fixture_accounts.token_messenger,
@@ -162,7 +162,7 @@ pub async fn execute_order_fallback(
         cctp_deposit_for_burn_token_minter: &token_minter,                             // 20
         cctp_deposit_for_burn_local_token: &local_token,                               // 21
         cctp_deposit_for_burn_token_messenger_minter_event_authority:
-            &token_messenger_minter_event_authority, // 22
+            token_messenger_minter_event_authority, // 22
         cctp_deposit_for_burn_token_messenger_minter_program: &TOKEN_MESSENGER_MINTER_PROGRAM_ID, // 23
         cctp_deposit_for_burn_message_transmitter_program: &MESSAGE_TRANSMITTER_PROGRAM_ID, // 24
         core_bridge_program: &CORE_BRIDGE_PROGRAM_ID,                                       // 25
@@ -175,14 +175,14 @@ pub async fn execute_order_fallback(
     };
 
     let execute_order_ix = ExecuteOrderCctpShim {
-        program_id: program_id,
+        program_id,
         accounts: execute_order_ix_accounts,
     }
     .instruction();
 
     // Considering fast forwarding blocks here for deadline to be reached
     let recent_blockhash = test_ctx.borrow().last_blockhash;
-    utils::setup::fast_forward_slots(&testing_context, 3).await;
+    utils::setup::fast_forward_slots(testing_context, 3).await;
     let transaction = Transaction::new_signed_with_payer(
         &[execute_order_ix],
         Some(&payer_signer.pubkey()),
@@ -230,7 +230,7 @@ pub async fn execute_order_fallback_test(
         testing_context.testing_state.transfer_direction,
     );
     execute_order_fallback(
-        &testing_context,
+        testing_context,
         &testing_context.testing_actors.owner.keypair(),
         &testing_context.get_matching_engine_program_id(),
         solver,

solana/programs/matching-engine/tests/shimless/execute_order.rs

@@ -57,7 +57,7 @@ pub fn create_execute_order_shimless_accounts(
     };
     let wormhole_publish_message = WormholePublishMessage {
         config: wormhole_svm_definitions::solana::CORE_BRIDGE_CONFIG,
-        emitter_sequence: emitter_sequence,
+        emitter_sequence,
         fee_collector: wormhole_svm_definitions::solana::CORE_BRIDGE_FEE_COLLECTOR,
         core_bridge_program: wormhole_svm_definitions::solana::CORE_BRIDGE_PROGRAM_ID,
     };
@@ -158,7 +158,7 @@ pub async fn execute_order_shimless_test(
     payer_signer: &Rc<Keypair>,
     expected_error: Option<&ExpectedError>,
 ) -> Option<ExecuteOrderShimlessFixture> {
-    crate::utils::setup::fast_forward_slots(&testing_context, 3).await;
+    crate::utils::setup::fast_forward_slots(testing_context, 3).await;
     let fixture_accounts = testing_context
         .get_fixture_accounts()
         .expect("Fixture accounts not found");

solana/programs/matching-engine/tests/testing_engine/engine.rs

@@ -536,21 +536,21 @@ impl TestingEngine {
         let auction_accounts = current_state
             .auction_accounts()
             .expect("Auction accounts not found");
-        let fast_market_order_address = config.fast_market_order_address.unwrap_or(
+        let fast_market_order_address = config.fast_market_order_address.unwrap_or_else(|| {
             current_state
                 .fast_market_order()
                 .expect("Fast market order is not created")
-                .fast_market_order_address,
-        );
+                .fast_market_order_address
+        });
         let active_auction_state = current_state
             .auction_state()
             .get_active_auction()
             .expect("Active auction not found");
         let result = shimful::shims_execute_order::execute_order_fallback_test(
             &self.testing_context,
-            &auction_accounts,
+            auction_accounts,
             &fast_market_order_address,
-            &active_auction_state,
+            active_auction_state,
             solver,
             config.expected_error.as_ref(),
         )
@@ -584,7 +584,7 @@ impl TestingEngine {
         let payer_signer = config
             .payer_signer
             .clone()
-            .unwrap_or(self.testing_context.testing_actors.owner.keypair());
+            .unwrap_or_else(|| self.testing_context.testing_actors.owner.keypair());
         let auction_config_address = current_state
             .auction_config_address()
             .expect("Auction config address not found");